@donho & @ozone10:

Let’s remove (comment) it. We will see users’ reaction about this feature to add it back, or to add an non-GUI option in config, or even an empty xml file as sentinel for enable this option.

I have tested the NPP commit with my Fixed-Width Data Visualizer plugin and providing the relevant feedback here.

Darkmode support was added to the FWDataViz plugin soon after it featured in NPP, over a year ago. Now with the generic darkmode rendering for all plugin dock panels in NPP, I was interested to see if this caused issues with FWDataViz which already had its own darkmode support. My observations:

1. Thankfully, there were no crashes or interface blemishes when NPP’s generic darkmode rendering and the plugin’s own darkmode rendering were both simultaneously active.

2. Also, the plugin panel was getting the darkmode enable/disable toggles and tone changes immediately, with no restart required in NPP. This could be because maybe I missed turning off all the darkmode render code in FWDataViz, OR I am misunderstanding this statement:

Also current implementation require restart, user still must close Notepad++ to apply new config.

3. When I had just the NPP darkmode rendering active, it failed to do its job only on the three-state checkbox on the FWDataViz side panel.
   
   That can be easily fixed, if needed, in the NPP darkmode render code by accounting for BS_AUTO3STATE controls as seen in these code snippets from the adapted version of NppDarkmode.cpp for the FWDataViz plugin:

...
         if (wcscmp(className, WC_BUTTON) == 0)
         {
            auto nButtonStyle = ::GetWindowLongPtr(hwnd, GWL_STYLE) & 0xF;
            switch (nButtonStyle)
            {
               case BS_CHECKBOX:
               case BS_AUTOCHECKBOX:
               case BS_AUTO3STATE:
               case BS_RADIOBUTTON:
               case BS_AUTORADIOBUTTON:
                  if (p.subclass)
                  {
                     subclassButtonControl(hwnd);
                  }
                  break;
...
...
...
      int iPartID = BP_CHECKBOX;
      if (nButtonStyle == BS_CHECKBOX || nButtonStyle == BS_AUTOCHECKBOX || nButtonStyle == BS_AUTO3STATE)
      {
         iPartID = BP_CHECKBOX;
      }
...

4. The generic darkmode render code also doesn’t support any other popup dialogs that are opened by the FWDataViz plugin. This clip was taken by turning off FWDataViz’s own darkmode rendering, and with just NPP’s generic darkmode rendering in action.
   

5. In view of the preceding observation and to avoid the needless double rendering of darkmode for the plugin, I had to add the DWS_USEOWNDARKMODE flag to FWDataViz’s dock panel creation code to turn-off the generic darkmode rendering from NPP, and turn on the FWDataViz’s custom darkmode rendering.
   

The changes made to FWDataViz code along with other issue fixes are already available in the latest FWDataViz 2.5.2.0 release.