v7.3.3 - Fix CIA Hacking Notepad++ issue

Quppa

As you note, if the hackers have the ability to drop a DLL into the Notepad++ application directory, they can probably do just about anything they want. They’re already on the other side of the airtight hatchway, as Raymond Chen would put it.

cipher-1024

Don,
Thank you for adding the “Improve multi-line tab: maintaining the selected tab position.” feature. That will make life easier for me. Sadly, that feature seems to have disabled the tab drag-and-drop ability when in mulit-line mode. Maintaining the rows of tabs is more important to me, but if both functions could work together, that would be great.

Thanks also for doing the scilexer.dll fix. Regardless of how compromised the system is, I’m glad you have the pride to do everything you can to make sure it doesn’t happen in your house.

Respect

yarumoSan

Wear a safety reflector and use anti-virus is all that most people need to know. Patching just 1 car has little effect on overall security.

GlacialManYT

Hi and thanks for all. Maybe, my problem but I see the error of SciLexer.dll starting Notepad++ 32-bit on Win 10 Pro 64-bit Anniversary Edition. Has anyone noticed the same?

Claudia Frank

@GlacialManYT

What exactly is the error message?
and do you have a SciLexer.dll in the directory where notepad++.exe has been installed?

Cheers
Claudia

GlacialManYT

C:\Program Files (x86)\Notepad++\SciLexer.dll
CRC32: 7ffc0f72

Certificate checking
Check certificate of C:\Program Files (x86)\Notepad++\SciLexer.dll : Impossible to find the specified object
OK

Exception on WM_CREATE
ScintillaEditView::init : SCINTILLA ERROR - can not load the dynamic library
OK

Claudia Frank

@GlacialManYT

and from where did you download notepad++?

Cheers
Claudia

GlacialManYT

https://notepad-plus-plus.org/repository/7.x/7.3.3/npp.7.3.3.Installer.exe
CRC32: 8e15096a
I also tried to disable AV and to install as admin

Sorry but I’m a new user, I haven’t earned 2 reputation and I can only post once every 1200 seconds…

Claudia Frank

@GlacialManYT

OK, I installed VirtualBox and loaded my aged Winodws 10 64bit VM,
Downloaded npp7.3.3 (32bit) and installed it.
Started npp - no problem. (The only problem is that it takes ages because of my old pc isn’t really capable of doing it.)

So what is specific to your setup? Any ideas?

Cheers
Claudia

donho

@GlacialManYT said:

Certificate checking
Check certificate of C:\Program Files (x86)\Notepad++\SciLexer.dll : Impossible to find the specified object

It seems your SciLexer.dll in C:\Program Files (x86)\Notepad++ is not signed.
Could you send me your SciLexer.dll to don.h@free.fr please?

GlacialManYT

E-Mail message sent.

donho

@GlacialManYT Thank you.
I have checked. The file (scilexer.dll) is correct.
Could you

make sure your OS is updated and restart your PC.
download minimalist package both 32/64 bith version from notepad-plus-plus.org, create npp32 & npp32 under *c:\temp*, unzip both into c:\temp\npp32 & c:\temp\npp64 respectively, then give both a try?

guy038

Hello, Don,

How are you ? Not too traumatized by the recent CIA Hacking issue. Thank you, for caring about our global security :-))

Don, from the discussion, between Jean Heck, Mkupper and Claudia :

https://notepad-plus-plus.org/community/topic/13374/double-click-links-no-longer-work/1

I realized some tests. And, indeed, there is a bug, with clickable links, in the last versions of Notepad++

To reproduce the bug :

Create a simple text file, named test.txt under the root C:\ of your machine
Start Notepad++
Open, first, any file, for instance, the change.log file
Now, in a new tab, type the single line, below :

file://C:/test.txt
Save this text file as Test_Lang.txt
Change the language of the Test_Lang.txt file to any language
Select the change.log file and, immediately, go back to the Test_Lang.txt file

( Note : this “switch” action allows to active the link, again ! )

Finally, double-click on the file://C:/test.txt link

=> I noticed that the double-click does NOT work, for the four languages ASP HTML JSP PHP, if the N++'s version is superior or equal to v7.3 !

For all other languages, included Normal Text, the double-click DOES work and opens, as expected, the test.txt file, in Microsoft Notepad :-)

Best Regards,

guy038

P.S :

Of course, I suppose that the option Enable, in Settings… > Preferences… > MISC. > Clickable Link Settings is checked !
Perhaps, the reason(s) why double-click doesn’t work for the four languages ASP, HTML, JSP and PHP is(are) not the same for each of them :-((

qma ster

I believe that enforcing the signature checking for just scilexer.dll is not enough:
if I were a hacker, after this patching if I still want to hack a Notepad++
I would just move to the next DLL !
Question: why not enforce the signature checking for all the Notepad++ DLLs?

GlacialManYT

Hi Don, thanks for your help, I will make the test that you have suggested, as soon as possible. I take this opportunity to point out a small anomaly. When in Notepad++ several files are opened (txt, bat, cmd), if I modify or I delete any of these files, and Notepad++ is opened in background, when I switch to Notepad++ an useful window asks to me if I want to update the situation. The problem comes when I modify or I delete an opened file and, after, without switching to Notepad++, I open a file, I expect that its tab is selected, in the foreground, but, after having responded to the question of the said window, file is not pointed and I must search for it in the open tabs of Notepad++ (that generally are many). After the answer, according to me, should be selected the tab of the last opened file (or in phase of opening). Obviously, if I have modified or deleted some files, the questions are one for each file and, at the end of the answers, as said, should be selected the tab of the last opened file (or in phase of opening). That’s all, not so important but useful.

dail

@guy038 @donho

I’ve opened https://github.com/notepad-plus-plus/notepad-plus-plus/pull/3019 which solves the issue with clicking links in certain file types.

GlacialManYT

@donho : I have deeply uninstalled notepad++ 32-bit v7.3.3 and, after, I have cleaned the registry but the error persists. I have the same problem with all 32-bit versions ( I made a test also with this http://portableapps.com/apps/development/notepadpp_portable ). Instead, all 64-bit versions are working regularly. So, I’m using the 64-bit version also if, for now, I would prefer the 32-bit version, that supports all plug-ins. I can make a test on others Windows 10 Pro 64-bit Anniversary Edition. See you soon.

Claudia Frank

@GlacialManYT

Can you run ProcMon to see what’s going on?
Once downloaded, start it, create a filter for SciLexer.dll (Path ends with)
make sure that (toolbar buttons) file system activity and process and thread activity
have been pressed and start npp.
What’s the result?

Cheers
Claudia

GlacialManYT

Thanks for your help Claudia, there was a system problem that I solved. Now all is ok.

guy038

Hi Dail,

Many thanks for quickly finding a fix about the clickable links bug, when file language is ASP, HTML, JSP or PHP !

Cheers,

guy038