v7.3.3 - Fix CIA Hacking Notepad++ issue

guy038

Hello, Don,

How are you ? Not too traumatized by the recent CIA Hacking issue. Thank you, for caring about our global security :-))

Don, from the discussion, between Jean Heck, Mkupper and Claudia :

https://notepad-plus-plus.org/community/topic/13374/double-click-links-no-longer-work/1

I realized some tests. And, indeed, there is a bug, with clickable links, in the last versions of Notepad++

To reproduce the bug :

Create a simple text file, named test.txt under the root C:\ of your machine
Start Notepad++
Open, first, any file, for instance, the change.log file
Now, in a new tab, type the single line, below :

file://C:/test.txt
Save this text file as Test_Lang.txt
Change the language of the Test_Lang.txt file to any language
Select the change.log file and, immediately, go back to the Test_Lang.txt file

( Note : this “switch” action allows to active the link, again ! )

Finally, double-click on the file://C:/test.txt link

=> I noticed that the double-click does NOT work, for the four languages ASP HTML JSP PHP, if the N++'s version is superior or equal to v7.3 !

For all other languages, included Normal Text, the double-click DOES work and opens, as expected, the test.txt file, in Microsoft Notepad :-)

Best Regards,

guy038

P.S :

Of course, I suppose that the option Enable, in Settings… > Preferences… > MISC. > Clickable Link Settings is checked !
Perhaps, the reason(s) why double-click doesn’t work for the four languages ASP, HTML, JSP and PHP is(are) not the same for each of them :-((

qma ster

I believe that enforcing the signature checking for just scilexer.dll is not enough:
if I were a hacker, after this patching if I still want to hack a Notepad++
I would just move to the next DLL !
Question: why not enforce the signature checking for all the Notepad++ DLLs?

GlacialManYT

Hi Don, thanks for your help, I will make the test that you have suggested, as soon as possible. I take this opportunity to point out a small anomaly. When in Notepad++ several files are opened (txt, bat, cmd), if I modify or I delete any of these files, and Notepad++ is opened in background, when I switch to Notepad++ an useful window asks to me if I want to update the situation. The problem comes when I modify or I delete an opened file and, after, without switching to Notepad++, I open a file, I expect that its tab is selected, in the foreground, but, after having responded to the question of the said window, file is not pointed and I must search for it in the open tabs of Notepad++ (that generally are many). After the answer, according to me, should be selected the tab of the last opened file (or in phase of opening). Obviously, if I have modified or deleted some files, the questions are one for each file and, at the end of the answers, as said, should be selected the tab of the last opened file (or in phase of opening). That’s all, not so important but useful.

dail

@guy038 @donho

I’ve opened https://github.com/notepad-plus-plus/notepad-plus-plus/pull/3019 which solves the issue with clicking links in certain file types.

GlacialManYT

@donho : I have deeply uninstalled notepad++ 32-bit v7.3.3 and, after, I have cleaned the registry but the error persists. I have the same problem with all 32-bit versions ( I made a test also with this http://portableapps.com/apps/development/notepadpp_portable ). Instead, all 64-bit versions are working regularly. So, I’m using the 64-bit version also if, for now, I would prefer the 32-bit version, that supports all plug-ins. I can make a test on others Windows 10 Pro 64-bit Anniversary Edition. See you soon.

Claudia Frank

@GlacialManYT

Can you run ProcMon to see what’s going on?
Once downloaded, start it, create a filter for SciLexer.dll (Path ends with)
make sure that (toolbar buttons) file system activity and process and thread activity
have been pressed and start npp.
What’s the result?

Cheers
Claudia

GlacialManYT

Thanks for your help Claudia, there was a system problem that I solved. Now all is ok.

guy038

Hi Dail,

Many thanks for quickly finding a fix about the clickable links bug, when file language is ASP, HTML, JSP or PHP !

Cheers,

guy038

AngryGamer

@cipher-1024 Thoughts on PR#3023 and Issue#3016?

Shyam Reddy

Hi,

Good day! Has anyone seeing this visually not pleasant multi-line tab bar since this update? Tabs now have got extra white space around making them look bad. Screenshot

AngryGamer

@Shyam-Reddy There’s a discussion about it on Issue#3007

Shyam Reddy

@AngryGamer said:

@Shyam-Reddy There’s a discussion about it on Issue#3007

Thanks AngryGamer. Hope this gets fixed. Sorry if I posted under wrong thread.

chicharones

Believe it or not, I’ve got a windows 2003 machines that I updated with 7.3.3 package.

The installer runs without issue and upgrades. However, launching notepad++ now triggers two “unknown exception” dialog boxes. I click okay after each. It seems to run fine after that.

I totally understand if windows 2003 is outside supported windows versions. I don’t have any dev tools on the machine to give you more information.

chcg

@chicharones In principle n++ should still support win xp sp3. Which service pack of 2003 do you use?

mkupper

@chicharones said:

Believe it or not, I’ve got a windows 2003 machines that I updated with 7.3.3 package.

The installer runs without issue and upgrades. However, launching notepad++ now triggers two “unknown exception” dialog boxes. I click okay after each. It seems to run fine after that.

Try disabling the plugins to see if it’s one of those.

Exit from npp and from a command prompt do:

cd /d "%ProgramFiles%\Notepad++\plugins"
md disabled
move *.dll disabled

Start npp and see if there are issues. If there are none then exit from and start testing by moving DLLs from the disabled sub-folder back into plugins and starting/stopping npp to see if that’s the one that causes the issue.

I’m using 7.3.3 (23-bit) on Windows 2003 machines with all of the default plugins that npp comes with but it’s possible you have additional plugins.

StarBeat HD

@GlacialManYT said:

Thanks for your help Claudia, there was a system problem that I solved. Now all is ok.

Hello, I have the same problem with the x32 application. You can tell how you solved this problem. Thank you.

AngryGamer

@donho Can you review PR#3023? I’d like to know if further changes are necessary before I move onto other stuff.

donho

@AngryGamer said:

@donho Can you review PR#3023? I’d like to know if further changes are necessary before I move onto other stuff.

I’ll check this evening (Paris time).

donho

@GlacialManYT said:

After the answer, according to me, should be selected the tab of the last opened file (or in phase of opening). Obviously, if I have modified or deleted some files, the questions are one for each file and, at the end of the answers, as said, should be selected the tab of the last opened file (or in phase of opening). That’s all, not so important but useful.

It’s not the expacted behaviour in Notepad++.
I just tested under my v7.3.3, each question (dialog) comes with the file in question revealed.
Have you try to remove all plugins to make sure it’s not a plugin issue?

GlacialManYT

@StarBeat-HD
I thought it was an application issue, so, I have made related operations like

installation and deep uninstallation of both versions
elimination of all references “notepad++” from the registry
elimination of all references from the %systemdrive%
Therefore, not having solved, I tried to repair the system
Malware / Spyware check
sfc /scannow (for my OS was unuseful but is not a bad idea)
reinstallation of the runtimes only (my OS is always updated and all the .Net are ok, because are continously used by the applications, so, I haven’t checked them)
But I solved with the repair of the permissions, I used “Windows Repair Free” made by “Tweaking.com”. I only selected the first 4 “repairs” but, for other cases, is possible that are needed also some other repairs. Good work and good luck…