v7.3.3 - Fix CIA Hacking Notepad++ issue

qma ster

I believe that enforcing the signature checking for just scilexer.dll is not enough:
if I were a hacker, after this patching if I still want to hack a Notepad++
I would just move to the next DLL !
Question: why not enforce the signature checking for all the Notepad++ DLLs?

GlacialManYT

Hi Don, thanks for your help, I will make the test that you have suggested, as soon as possible. I take this opportunity to point out a small anomaly. When in Notepad++ several files are opened (txt, bat, cmd), if I modify or I delete any of these files, and Notepad++ is opened in background, when I switch to Notepad++ an useful window asks to me if I want to update the situation. The problem comes when I modify or I delete an opened file and, after, without switching to Notepad++, I open a file, I expect that its tab is selected, in the foreground, but, after having responded to the question of the said window, file is not pointed and I must search for it in the open tabs of Notepad++ (that generally are many). After the answer, according to me, should be selected the tab of the last opened file (or in phase of opening). Obviously, if I have modified or deleted some files, the questions are one for each file and, at the end of the answers, as said, should be selected the tab of the last opened file (or in phase of opening). That’s all, not so important but useful.

dail

@guy038 @donho

I’ve opened https://github.com/notepad-plus-plus/notepad-plus-plus/pull/3019 which solves the issue with clicking links in certain file types.

GlacialManYT

@donho : I have deeply uninstalled notepad++ 32-bit v7.3.3 and, after, I have cleaned the registry but the error persists. I have the same problem with all 32-bit versions ( I made a test also with this http://portableapps.com/apps/development/notepadpp_portable ). Instead, all 64-bit versions are working regularly. So, I’m using the 64-bit version also if, for now, I would prefer the 32-bit version, that supports all plug-ins. I can make a test on others Windows 10 Pro 64-bit Anniversary Edition. See you soon.

Claudia Frank

@GlacialManYT

Can you run ProcMon to see what’s going on?
Once downloaded, start it, create a filter for SciLexer.dll (Path ends with)
make sure that (toolbar buttons) file system activity and process and thread activity
have been pressed and start npp.
What’s the result?

Cheers
Claudia

GlacialManYT

Thanks for your help Claudia, there was a system problem that I solved. Now all is ok.

guy038

Hi Dail,

Many thanks for quickly finding a fix about the clickable links bug, when file language is ASP, HTML, JSP or PHP !

Cheers,

guy038

AngryGamer

@cipher-1024 Thoughts on PR#3023 and Issue#3016?

Shyam Reddy

Hi,

Good day! Has anyone seeing this visually not pleasant multi-line tab bar since this update? Tabs now have got extra white space around making them look bad. Screenshot

AngryGamer

@Shyam-Reddy There’s a discussion about it on Issue#3007

Shyam Reddy

@AngryGamer said:

@Shyam-Reddy There’s a discussion about it on Issue#3007

Thanks AngryGamer. Hope this gets fixed. Sorry if I posted under wrong thread.

chicharones

Believe it or not, I’ve got a windows 2003 machines that I updated with 7.3.3 package.

The installer runs without issue and upgrades. However, launching notepad++ now triggers two “unknown exception” dialog boxes. I click okay after each. It seems to run fine after that.

I totally understand if windows 2003 is outside supported windows versions. I don’t have any dev tools on the machine to give you more information.

chcg

@chicharones In principle n++ should still support win xp sp3. Which service pack of 2003 do you use?

mkupper

@chicharones said:

Believe it or not, I’ve got a windows 2003 machines that I updated with 7.3.3 package.

The installer runs without issue and upgrades. However, launching notepad++ now triggers two “unknown exception” dialog boxes. I click okay after each. It seems to run fine after that.

Try disabling the plugins to see if it’s one of those.

Exit from npp and from a command prompt do:

cd /d "%ProgramFiles%\Notepad++\plugins"
md disabled
move *.dll disabled

Start npp and see if there are issues. If there are none then exit from and start testing by moving DLLs from the disabled sub-folder back into plugins and starting/stopping npp to see if that’s the one that causes the issue.

I’m using 7.3.3 (23-bit) on Windows 2003 machines with all of the default plugins that npp comes with but it’s possible you have additional plugins.

StarBeat HD

@GlacialManYT said:

Thanks for your help Claudia, there was a system problem that I solved. Now all is ok.

Hello, I have the same problem with the x32 application. You can tell how you solved this problem. Thank you.

AngryGamer

@donho Can you review PR#3023? I’d like to know if further changes are necessary before I move onto other stuff.

donho

@AngryGamer said:

@donho Can you review PR#3023? I’d like to know if further changes are necessary before I move onto other stuff.

I’ll check this evening (Paris time).

donho

@GlacialManYT said:

After the answer, according to me, should be selected the tab of the last opened file (or in phase of opening). Obviously, if I have modified or deleted some files, the questions are one for each file and, at the end of the answers, as said, should be selected the tab of the last opened file (or in phase of opening). That’s all, not so important but useful.

It’s not the expacted behaviour in Notepad++.
I just tested under my v7.3.3, each question (dialog) comes with the file in question revealed.
Have you try to remove all plugins to make sure it’s not a plugin issue?

GlacialManYT

@StarBeat-HD
I thought it was an application issue, so, I have made related operations like

installation and deep uninstallation of both versions
elimination of all references “notepad++” from the registry
elimination of all references from the %systemdrive%
Therefore, not having solved, I tried to repair the system
Malware / Spyware check
sfc /scannow (for my OS was unuseful but is not a bad idea)
reinstallation of the runtimes only (my OS is always updated and all the .Net are ok, because are continously used by the applications, so, I haven’t checked them)
But I solved with the repair of the permissions, I used “Windows Repair Free” made by “Tweaking.com”. I only selected the first 4 “repairs” but, for other cases, is possible that are needed also some other repairs. Good work and good luck…

GlacialManYT

@donho said:

It’s not the expacted behaviour in Notepad++.
I just tested under my v7.3.3, each question (dialog) comes with the file in question revealed.
Have you try to remove all plugins to make sure it’s not a plugin issue?

Very probable, I reproduced the problem using a 32-bit full version and a 32-bit minimalist, on a 64-bit Win 10 (some days ago, I have noticed the mentioned problem on a 64-bit Win 7, where I want execute the same test). Thanks to this test I noticed that the problem occurs using the full version only. For the full version, I had executed a default installation, I had only selected the italian language. I think this is not useful but, during the test, I executed the minimalist version (ok) from the zip package (by WinRAR) on a OS where is installed the full version (not ok). Have you any suggestion? thanks.