Notepad++ 7.9 RC3

donho

I found a bug regarding .nfo-files, i.e. MS-DOS-Style text files containing images or graphic elements created with the ASCII character set. Trying to open any file with the file extension ‘.nfo’ results in Np++ to crash.

I cannot reproduce the crash with ascii art anf extension nfo.
Could you provide your nfo for reprocing the crash please?

PeterJones

@donho / @deus-ex ,

Early this year, there was some discussion here – when used in combination with Hex Editor plugin installed (even if it wasn’t active), that loading NFO files (even if it’s just plain text, or even just an empty file named blah.nfo) could cause v7.8.4 to crash – and that either associating NFO extension with something else (UDL or Search Results or anything else to prevent the NFO lexer from engaging) was able to prevent the crash, or the crash could be avoided by uninstalling Hex Editor. Apparently @Fourbits (the poster from that conversation) never followed through to file a bug report. At the time, I was able to replicate the bug in a freshly installed v7.8.4-32bit. (I don’t remember, but I think it didn’t show up in portable… but I could be wrong on that.)

Since in the first v7.9 RC thread @deus-ex was using the Hex Editor with RC1, I think it’s probably related to the Hex Editor still.

Given that the NFO “lexer” only has the one default style, my guess is that NFO lexer’s primary purpose is to set the right encoding to work with the NFO’s typical box-drawing characters (OEM-US = CP437); I wonder if Hex Editor tries to set the encoding and NFO lexer tries to set the encoding and maybe that’s what’s causing the problem (I don’t know – I don’t actually use either).

If it really is caused by the interaction of NFO and Hex Editor, then I don’t think this is a regression in v7.9, since v7.8.4 had the same problem. So I would recommend that @deus-ex file a bug report in the github tracker, so @donho can look at it further later. But it’s really up to Don, whether he wants to hold up the v7.9 release for this.

Michael Vincent

@PeterJones said in Notepad++ 7.9 RC3:

f it really is caused by the interaction of NFO and Hex Editor,

Anecdotal evidence confirms this as I took 7.9RC3 and new 64 ZIP manual install and added Hex Editor plugin:

Notepad++ v7.9 (64-bit)
Build time : Sep 22 2020 - 03:19:04
Path : C:\Users\mvincent\tmp\npp64\notepad++.exe
Admin mode : OFF
Local Conf mode : ON
OS Name : Windows 10 Enterprise (64-bit)
OS Version : 1909
OS Build : 18363.418
Current ANSI codepage : 1252
Plugins : HexEditor.dll

Opening an NFO file with File->Open seems to work OK. However, from the command line:

C:\> notepad++.exe test.nfo

Does cause a “crash” - Notepad++ opens and then closes - no error message is thrown to screen.

I would agree this is plugin related and probably Hex Editor plugin related (as I don’t regularly use it or load it and as shown previous, I could not replicate the error).

Cheers.

Alan Kilborn

So I would recommend that @deus-ex file a bug report in the github tracker, so @donho can look at it further later. But it’s really up to Don, whether he wants to hold up the v7.9 release for this.

It seems like some people like to use these RC announcement threads to report bugs that aren’t specifically related to the RC itself (which is annoying/distracting).

Why would they do this?

Because (obviously) these threads have @donho 's attention, whereas typical threads here do not, and “one more issue” on github tends to be somewhat ignored/lost with all the others…

donho

@PeterJones said in Notepad++ 7.9 RC3:

Since in the first v7.9 RC thread @deus-ex was using the Hex Editor with RC1, I think it’s probably related to the Hex Editor still.

I have also HexEdit (0.9.7) installed, but no crash.
Here my debug info:

Notepad++ v7.8.9   (32-bit)
Build time : Sep 22 2020 - 15:53:59
Path : C:\xxxxx\notepad-plus-plus\PowerEditor\visual.net\..\bin\Notepad++.exe
Admin mode : OFF
Local Conf mode : ON
OS Name : Windows 10 Enterprise (64-bit) 
OS Version : 2004
OS Build : 19041.508
Current ANSI codepage : 1252
Plugins : HexEditor.dll mimeTools.dll NppConverter.dll NppExport.dll XMLTools.dll

deus ex

@donho @PeterJones @Michael-Vincent

@PeterJones said in Notepad++ 7.9 RC3:

If it really is caused by the interaction of NFO and Hex Editor, then I don’t think this is a regression in v7.9, since v7.8.4 had the same problem. So I would recommend that @deus-ex file a bug report in the github tracker, so @donho can look at it further later. But it’s really up to Don, whether he wants to hold up the v7.9 release for this.

I can confirm that the HexEditor plugin is indeed the cause for the described issues with the ‘.nfo’ file extension. I just removed the HexEditor plugin, now files with a ‘.nfo’ file extension don’t cause a crash, and files with ASCII art are displayed correctly again.

I raised a bug report accordingly: #8884

donho

@Alan-Kilborn said in Notepad++ 7.9 RC3:

Why would they do this?
Because (obviously) these threads have @donho 's attention, whereas typical threads here do not, and “one more issue” on github tends to be somewhat ignored/lost with all the others…

I (and others) do my best to treat the issues. If you are not happy about it, stop whining and help us to do it.

deus ex

@donho

@donho said in Notepad++ 7.9 RC3:

I have also HexEdit (0.9.7) installed, but no crash.

I also do not get any crash with Np++ v7.8. I verified that both with NpHex Editor v0.9.6 and v0.9.7. However Np++ 7.9 RC1-3, which require NpHex Editor v0.9.7, does crash.

deus ex

@donho

In my earlier post above I wrote:
“However, trying to define an entry ‘Language name=“MS-DOS Style”’ in langs.xml does not seem to have any effect. Is this an oversight, and can this be fixed?”

Can you please check why the entry ‘Language name=“MS-DOS Style”’ seems not to work? Perhaps I made a mistake?

donho

@deus-ex
Here is for the RC regression issues. Let’s talk in:
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8884

Alan Kilborn

@donho said in Notepad++ 7.9 RC3:

I (and others) do my best to treat the issues. If you are not happy about it, stop whining and help us to do it.

@donho You missed my point by so far it is amazing, but I guess that is what happens sometimes with non-native English speakers. There was no whining here, except against people that think they get your direct attention for their “pet” issues by typing into an RC announcement thread. Which, astoundingly, sometimes works.

BTW, I do “help us do it”, not by treating issues directly, but by answering questions here. Check my “reputation” score. You’re welcome. :-)

deus ex

@donho @ArkadiuszMichalski @vinsworldcom

Thanks to the help of you guys over at GitHub the issue has been solved. Don provided a binary of the NppHexedit plugin that does not produce the reported crash. A huge thank you to you guys, again!

Don, could you please comment on whether there exists an entry ‘Language name=“MS-DOS Style”’, and if not, how so? Thank you.

deus ex

@Alan-Kilborn said in Notepad++ 7.9 RC3:

@donho You missed my point by so far it is amazing, but I guess that is what happens sometimes with non-native English speakers. There was no whining here, except against people that think they get your direct attention for their “pet” issues by typing into an RC announcement thread. Which, astoundingly, sometimes works.

Besides this being Don’s forum, thus as a homeowner it’s solely his decision how he handles things, it says nowhere that you cannot address issues in an announcement thread. I guess the fact that the announcement threads are left open supports my point.

Alan Kilborn

@deus-ex

it says nowhere that you cannot address issues in an announcement thread

Don tried to tell you, here:

Here is for the RC regression issues. Let’s talk in (somewhere else).

donho

@Alan-Kilborn said in Notepad++ 7.9 RC3:

but I guess that is what happens sometimes with non-native English speakers.

Sorry for my misunderstanding and aggressiveness - I guess I become paranoid after receiving all the insulting emails. :)

BTW, I do “help us do it”, not by treating issues directly, but by answering questions here. Check my “reputation” score. You’re welcome. :-)

Well, thank you very much - without community, Notepad++ cannot be what it is today!

deus ex

@Alan-Kilborn said in Notepad++ 7.9 RC3:

@deus-ex

Don tried to tell you, here:

Here is for the RC regression issues. Let’s talk in (somewhere else).

And that was when I answered his request and continued the discussion somewhere else. Yet that is no proof of a general rule.

guy038

Hello @don-ho and All,

With delay, many thanks for the new release ! Contrary to the other times, I can’t say that some points are especially interesting as all of them seem to be important ;-))

Here are the contents of the v7.9 change.log file with the corresponding GitHub links, relative to each point. I certainly could miss some links but this list can be useful to shed some light on a particular point !

Two remarks :

Point 14 : Add keyboard shortcuts for switching to panels should be changed as Add keyboard shortcuts for switching to Projects, Folder as Workspace and Function List panels as these shortcuts do not concern all panels !
I added these two points :

28. Fix Escape key on FunctionList’s text field causing bell sound.
29. Include newest nppPluginList in which HexEdit is updated to 0.9.7 (Fixed exception in v7.9 and supported 64 bits).

Here is my new list :

Notepad++ v7.9 Enhancements & bug-fixes:

1.  Add the ability to open the target file of a Shortcut (*.lnk).
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8483
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8810

2.  Enhance side panels behaviour: close a single panel instead of the entire stack.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8471
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8753

3.  Fix Monitoring & document auto-update not scrolling to the end of the file with Word wrap enabled issue.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8850
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8851

https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8214
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8477

4.  Fix mouse cursor flicker while hovering URLs.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8588
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8641
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8647

5.  Add back hovered blue underlined URLs.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8654
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8713
( https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8769 )

6.  Enhance C++, Perl, Python parsers and add VHDL in Function List. 
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8480
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8509

7.  Improve some ambiguous commands naming in Shortcut Mapper.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8689
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8690

8.  Add an option to prevent right click from cancelling selection.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8563
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8564

9.  Add ability to sort lines randomly.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8682
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8683

10. Fix "Close All BUT this" looses current document data issue.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8617

11. Allow user to start making a stream selection and then change to column block (by pressing ALT key).
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8555
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8557

12. Add word wrap option to find results context menu.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8624
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8681

13. Add keyboard navigation ability to Column Editor.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8488
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8569

14. Add keyboard shortcuts for switching to panels.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8719
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8720

15. Enable project panels toggle from menu.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8471
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8533

16. Enhance Folder as Workspace to restore latest selected item of last session on Notepad++ startup.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8353

17. Fix inaccurate line margin update with word wrap enabled.
https://github.com/notepad-plus-plus/notepad-plus-plus/commit/fe18e41d5d0895c481817bc3566f61f0056dc879

18. Fix Find previous/next commands not scroll vertically to show match result issue (with word wrap disabled).
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8804
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8818

19. Fix column key sort with col block starting in col1 bug.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8716
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8717

20. Add confirmation preference for Replace All in All Opened Documents operation.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8527
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8708

21. Add Escape keypress in functionlist searchbox to clear its text.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8667
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8789

22. Add RTL capability to localized messageboxes.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8699
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8701

23. Make (Find) dlgAlwaysVisible a true Preference setting.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/7908
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8651

24. Fix sorting by column key using incorrect key values.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8674
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8675

25. Add search scope to Find window status bar output.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8632
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8639

26. Fix false hit result in Find in Finder.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8435
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8437

27. Prevent redundant line data copy in Finder.
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8580
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8620

28. Fix Escape key on FunctionList’s text field causing bell sound.
https://github.com/notepad-plus-plus/notepad-plus-plus/commit/f3fce2de4a5bf17143af9df31e67f4162d215f70

29. Include newest nppPluginList in which HexEdit is updated to 0.9.7 (Fixed exception in v7.9 and supported 64 bits).
See  https://github.com/chcg/NPP_HexEdit/releases


See also :

https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8131
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8541

https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8696
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/8760
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/7638

Best Regards,

guy038

donho

@guy038,

Hi Guy,

Nice to see you here again!

Add keyboard shortcuts for switching to panels should be changed as Add keyboard shortcuts for switching to Projects, Folder as Workspace and Function List panels as these shortcuts do not concern all panels !

Good point!
However, after checking again this feature, I would reword it to Add keyboard shortcut ability to Projects, Folder as Workspace and Function List panels for switching among them. The term “ability” is used because the shortcuts are not added, but users can add them via Shortcut Mapper. What do you think?

I added these two points :
28. Fix Escape key on FunctionList’s text field causing bell sound.
29. Include newest nppPluginList in which HexEdit is updated to 0.9.7 (Fixed exception in v7.9 and supported 64 bits).

Escape key on FunctionList’s text field was added in v7.9, so the bug does not exist for the most of Notepad++ users (except us). So 28. is not meaningful in the change log.
Same for 29.: Since the newest version of nppPluginList is always included on Notepad++ release, it’s not necessary to mention it each time. It was mentioned for the delta between RC2 and RC3 (for people in this forum), because of a crash bug of HexEdit detected on v7.9.

Here is my new list :

Thank you for the list!

guy038

Hi @don-ho and All,

Don, you said :

I would reword it to Add keyboard shortcut ability to Projects, Folder as Workspace and Function List panels for switching among them…

Thank you for asking me my feeling about it ! After all, it’s your product, isn’t it ? But, indeed, this new phrasing seems more accurate !

OK for messages about missing points 28 and 29, too !

Cheers,

guy038

P.S. I’ll certainly duplicate this list, when N++ version 7.9 is announced :-)

donho

@guy038 said in Notepad++ 7.9 RC3:

Thank you for asking me my feeling about it ! After all, it’s your product, isn’t it ?

A product cannot go far without a great community.
It’s always better to get people’s thinking to forge the direction of product.
In this way, Notepad++ is rather a product of community, my role is just a filter to guide the product going more smoothly.

Thank you everyone who’s contributed to this forum and to the project on GitHub!