Notepad++ 7.7 Release Candidate

andrecool-68

@donho
If it’s not hard for you … add these already verified fixes.
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/5592
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/5523
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/5597/commits/3a2212383b8f5ab6b4c884cdebb1e909abf9c565

andrecool-68

@donho I apologize for perseverance)))

Alan Kilborn

@donho said:

Language enhancement: Force Python files to use spaces instead of tabs.

This one should really be “4. Python files default to using spaces instead of tabs (for new installations)”.

Ekopalypse

@donho

The pythonscript plugin test suite throws many errors in version 7.7.
I’m currently not able to dig deeper as I do have a work training tomorrow and on Tuesday. I will be back on Wednesday. At first glance it looks like most of the callback tests fail and in addition, I got a strange system low memory error while running the tests.

Note, the same tests passes, with the exception of the two known crashes, on version 7.6.6. I ran it multiple times.

So, if no one else is jumping in or you are saying not npps business, I could try to find out, on Wednesday, what might have caused this, but I’m not sure if I can finish it within the announced 4 days.

bahusoid

@Ekopalypse said:

The pythonscript plugin test suite throws many errors in version 7.7.

Most likely this issue due to Scintilla upgrade and some breaking changes in Scintilla API.

SinghRajenM

@donho
It is worth to look into the issue https://github.com/notepad-plus-plus/notepad-plus-plus/issues/5595 (this is caused by allowing undo after reload…) in v7.7.

donho

@SinghRajenM
I didn’t see this issue, thank you for heads up.
It’s fixed in the master, and will be in the next version:
https://github.com/notepad-plus-plus/notepad-plus-plus/commit/f07ae664b43d2f37e63ca49b254e7b3fa21d9498

donho

@Ekopalypse
I second what @bahusoid has said.
Unfortunately v7.7 will only go with the nppPluginList v.1.0.9 except if it’s the issue for the most of plugins.

Meta Chuh

@donho

while you’re reviewing commits, prior to a 7.7 release, please look at these:

critical for default users:
if a manually installed plugin is removed with plugins admin, the whole plugins folder gets deleted.

possible fix:
pull request: https://github.com/notepad-plus-plus/notepad-plus-plus/pull/5593
author: @SinghRajenM

more info (issue tracker):
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/5576

non critical but raising issues:
monitoring a file produces a reload dialog.

possible fix:
pull request: https://github.com/notepad-plus-plus/notepad-plus-plus/pull/5591
author: @SinghRajenM

more info (issue tracker):
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/5586

one thing that might be critical for corporate users:
virustotal warning, again with a jiangmin false positive for nsis installers using SetCompressor /SOLID lzma.
(like npp.7.7.Installer.exe and npp.7.7.Installer.x64.exe)

verified fix:
use “SetCompressor /FINAL lzma” in nppSetup.nsi for the 7.7 release (instead of SetCompressor /SOLID lzma)

virustotal reports:

npp.7.7.Installer.exe: https://www.virustotal.com/#/file/f48d1e338cfd1a038ed0009c8c8dfe4e74522be14b2feb60dbabcb65cf6c20ad/detection

npp.7.7.Installer.x64.exe: https://www.virustotal.com/#/file/905eec65adf63c1a03e5968f4a7d6bbe5f97762fe953020627a36c7c51c78d1d/detection

donho

@Alan-Kilborn said:

Python files default to using spaces instead of tabs (for new installations)

Good point.

donho

@Meta-Chuh said:

critical for default users:
if a manually installed plugin is removed with plugins admin, the whole plugins folder gets deleted.

It’s a bug, but not a critical one. Since we upgrade Scintilla from a very old version to a new one, I prefer to have minimum modification to deal with potential regression.

one thing that might be critical for corporate users:
virustotal warning, again with a jiangmin false positive for nsis installers using SetCompressor /SOLID lzma.
(like npp.7.7.Installer.exe and npp.7.7.Installer.x64.exe)

I’ve answered you by email but it seems the gmail treat my email address as spam.
Here is my answer in the email:
It’s not us who should “work around” this issue. This work around could work once or several times, but one day when it doesn’t work anymore, we have to find another work around, and then over and over again…
The best way is make these so-called “antivirus” fix it. With the amount of Notepad++ user base, I don’t worry about it.