About commit "Fix duplicate names in stylers.model.xml" and the closed issue 7965...

guy038

Hello, @don-ho,

Thanks for taking the issue, below, in consideration ! However, as it is closed,

https://github.com/notepad-plus-plus/notepad-plus-plus/issues/7965

I just want to point out that, regarding the txt2tags language, there are still differences between the names given in SciLexer.h and those in your commit, for the styles 13 and 14 ?!

https://github.com/notepad-plus-plus/notepad-plus-plus/blob/master/scintilla/include/SciLexer.h

#define SCE_TXT2TAGS_ULIST_ITEM 13  // Line 1559
#define SCE_TXT2TAGS_OLIST_ITEM 14  // Line 1560

https://github.com/notepad-plus-plus/notepad-plus-plus/commit/e309ec23ec28ac744fd397446a3921d45cd0c4cd

        <WordsStyle name="ULIST" styleID="13" fgColor="E300EE" bgColor="FFFFFF" fontName="" fontStyle="0" fontSize="" />  <!-- 1252 -->
        <WordsStyle name="OLIST" styleID="14" fgColor="E300EE" bgColor="FFFFFF" fontName="" fontStyle="0" fontSize="" />  <!-- 1253 -->

I’m not totally sure but it seems, that the part _ITEM, in the two names, should be removed in SciLexer.h, doesn’t it ?

Best Regards,

guy038

Alan Kilborn

@guy038

Why did you put this here and not into the github issue ?

guy038

Hi @alan-kilborn,

Just for two reasons :

Firstly, as a non-coder person, I’m a bit unfamiliar to the global management of the GitHub site !
Secondly, I didn’t think that it was worth to open a new issue for this small change :-)

Best Regards,

guy038

Alan Kilborn

@guy038 said in About commit "Fix duplicate names in stylers.model.xml" and the closed issue 7965...:

as a non-coder person, I’m a bit unfamiliar to the global management of the GitHub site !

Ha. Don’t be shy. Not just for coders! :-)

I didn’t think that it was worth to open a new issue for this small change

I wasn’t suggesting that; I meant to add it to the issue you had already done. Even when issues are closed, the discussion can continue, and that way all the info is in one place. The developers can even decide to reopen a closed issue based upon new infos.

guy038

Hi @alan-kilborn,

Hum… I’m quite silly ! I should have guessed that discussion still goes on, although an issue is closed. I’ll do so, next time !

But, thanks to your comment, I’m less unfamiliar to GitHub, by now ;-))

Cheers

guy038

Michael Vincent

@guy038 said in About commit "Fix duplicate names in stylers.model.xml" and the closed issue 7965...:

I’m not totally sure but it seems, that the part _ITEM, in the two names, should be removed in SciLexer.h, doesn’t it ?

I think it may be the other way around. SciLexer.h I believe is supplied from Scintilla so it’d be easier to change our (N++) file to match the names in the SciLexer.h header.

Cheers.