Notepad++ 7.9.1 RC2
-
@donho said in Notepad++ 7.9.1 RC2:
Fix the regression of mark margin colour for dark themes.
I don’t really understand how this is a “regression”.
Themes are notoriously poorly maintained, so…no big deal.
It’s like a bit of new text not being translated into a supported language: not a big deal and not a regression.
But whatever…My real reason for posting is that this “regression” was fixed by removing “Bookmark margin” from the non-default themes??
Wouldn’t it have been better to leave it the way it was, then when the user of a dark theme is “hit in the face” with a glaring UI element, they can at least go in and fix it by assigning a reasonable color. With RC2 if I select a dark theme, e.g. Obsidian, “Bookmark margin” doesn’t appear as a Style to change.NOTE: I’m not complaining at all, just trying to understand.
-
@Alan-Kilborn said in Notepad++ 7.9.1 RC2:
My real reason for posting is that this “regression” was fixed by removing “Bookmark margin” from the non-default themes??
?? What do you mean by that? Nothing has been removed.
See the commit.Wouldn’t it have been better to leave it the way it was,
I would say no, as this would affect all theme users, whether you need this setting or not.
-
@Ekopalypse said in Notepad++ 7.9.1 RC2:
?? What do you mean by that? Nothing has been removed.
If you unzip RC2 portable into a fresh folder, run it, select Obsidian theme,
Bookmark marginwon’t appear as something you can choose a style on. This is different behavior from RC1. It was “removed” by code, apparently.Wouldn’t it have been better to leave it the way it was,
I would say no, as this would affect all theme users, whether you need this setting or not.
This could be a valid point.
My point was that, after years of (my) being confused as to where the “bookmark margin” actually was because it wasn’t differentiated, I can now set a color for it, but that’s because I’m aware of the capability.
Other users that aren’t so aware, might now never know about its ability to be styled.
The way it was, a user could have said “WTF is this??” and then discovered what it was, and thought “Nice” and picked a good color for it, and moved on.
Of course the very best way to have dealt with it would have been for the developers to go through all of the themes and added an appropriate-to-each-theme color for the new addition.AGAIN: I am not complaining at all.
-
Please wait, until https://github.com/notepad-plus-plus/notepad-plus-plus/issues/9031#issue-724006387 is solved. I think next weekend, three days ahead …
-
@Alan-Kilborn
It was only in the default styler but NOT in the themes.I’m always of the opinion that you rather passively communicate new features,
to not break the already used ones. -
@Uhf7 said in Notepad++ 7.9.1 RC2:
Please wait, until https://github.com/notepad-plus-plus/notepad-plus-plus/issues/9031#issue-724006387 is solved. I think next weekend, three days ahead …
No worry, now the cadence of release will be more often.
-
My point was that, after years of (my) being confused as to where the “bookmark margin” actually was because it wasn’t differentiated, I can now set a color for it, but that’s because I’m aware of the capability.
You have the point. “regression” may not be the right term.
But from my viewpoint, a good tool is which doesn’t bother users (average ones, not power users). So since it’s still in RC state, I prefer make it right.If you unzip RC2 portable into a fresh folder, run it, select Obsidian theme, Bookmark margin won’t appear as something you can choose a style on. This is different behavior from RC1. It was “removed” by code, apparently.
But it shouldn’t happen. I’ll check it.
edit: what you observed in RC2 is correct behaviour. And I am sure it’s the same behaviour in RC(1)
-
-
That thread you linked has nothing to do with a regression caused by v7.9.1 RC2.
Please keep posts in this thread related specifically to this release candidate.
-
No news, good news.
The release will be available in a couple of the days.
