Filtering the shortcut mapper

Terry R

@deleelee
Worse, it works on the “Name” column instead. As if that will help identify a shortcut or possible conflict!

Terry

PS although to be fair there is possible reason why, if you are looking for a type of command. I.e. type “lined” and get all the line type commands. So there is some usefulness.

Mark Olson

@Terry-R said in Filtering the shortcut mapper:

Worse, it works on the “Name” column instead.

Not instead; it works by the Name column in every other tab too.

This is just a straight-up bug, because the Name column is searched for every tab, but the Shortcut tab is searche for every tab except for Scintilla Commands.

To be honest the searching could use an overhaul anyway. Maybe just something simple like “search terms are separated by spaces, if all search terms are matched by the shortcut or name for a command, show that command.”

See also:

deleelee

@Terry-R said in Filtering the shortcut mapper:

it works on the “Name” column instead

As pointed out below, it isn’t “instead”. All other tabs filter by the Name and Shortcut columns.

deleelee

@Mark-Olson said in Filtering the shortcut mapper:

the Name column is searched for every tab, but the Shortcut tab is searche for every tab except for Scintilla Commands.

Exactly. I’m pleased you think it’s a bug. I was wondering if it was actually designed that way but I had no idea why it would be.

Alan Kilborn

@deleelee said in Filtering the shortcut mapper:

I’m pleased you think it’s a bug.

Yes, it’s a bug with at least 2 official bug reports currently open and active regarding it.
There’s nothing more to do besides wait for it to be fixed.
Well, you could get on github (in one or both of those bug reports) and comment that you’d also like to see the the bug fixed – developers give attention to bugs that get the most “noise” there.

Mark Olson

@Alan-Kilborn said in Filtering the shortcut mapper:

There’s nothing more to do besides wait for it to be fixed.

I’m going to try my hand at it. This looks a lot easier to fix and less likely to be fixed by someone else than most of the other bugs that I’ve seen recently.

Alan Kilborn

@Mark-Olson said in Filtering the shortcut mapper:

I’m going to try my hand at it.

Go for it.
It’s one of those I myself haven’t had sufficient interest in tackling…to this point.

BTW, there’s some other shortcut-related problems, so once you’re especially familiar with some of that code, you could tackle some others. :-)

Mark Olson

Should be fixed by this PR.

deleelee

@Mark-Olson said in Filtering the shortcut mapper:

Should be fixed by this PR .

Fantastic, Mark, thanks for taking the time to give it a go. Hopefully it won’t be too long before it’s implemented in a future update.

Alan Kilborn

@deleelee said in Filtering the shortcut mapper:

Hopefully it won’t be too long before it’s implemented in a future update.

You can try it out now by going HERE.

Choose the “build” for the Notepad++ you use under “Jobs” on the left and then follow the red arrows in the following to download a zip file containing a trial notepad++.exe:

Rename your original notepad++.exe and then copy the downloaded one to the N++ folder.

Start N++ as usual and try out the change.

Mark Olson

I have also implemented my idea of filtering the shortcut mapper by each whitespace-separated word in the search term in my local fork. I haven’t submitted a PR, but I’ve created an issue here. Check it out if you want to share your thoughts.

deleelee

@Alan-Kilborn said in Filtering the shortcut mapper:

You can try it out now by going HERE .

Thank you so much, Alan, for that detailed explanation. You made it really easy.

deleelee

@Mark-Olson said in Filtering the shortcut mapper:

I have also implemented my idea of filtering the shortcut mapper by each whitespace-separated word in the search term in my local fork. I haven’t submitted a PR, but I’ve created an issue here. Check it out if you want to share your thoughts.

I’ve checked out your fix for the Scintilla shortcut filter and it works great! Well done, and thanks again for taking the time to give it a go. And I’ve commented on this new issue you’ve created. Another great idea.

Mark Olson

The proposed feature of filtering the shortcut mapper has been added to Notepad++ via this commit.

See this issue in the user manual repo for some examples of how the new functionality will work.