Notepad++ 7.8.1 Release Candidate

donho

@dinkumoil said in Notepad++ 7.8.1 Release Candidate:

I use a 2-monitor setup in extended desktop mode and run Notepad++ on second monitor. When downloading plugins, the progress bar dialog pops up at the first monitor. If there are other windows open (e.g. Explorer window) placed in the center of the screen, the download progress bar is hidden by these windows.

Maybe Add download progress bar while download plugin(s). should not be here because it’s the enhancement in WinGUp but not in Notepad++.
I put it here because Notepad++ present the whole solution including the used components, and the most of people download the installer.

rinku singh

@gurikbal-singh said in Notepad++ 7.8.1 Release Candidate:

hi i was on win 32 OS where installer has invisible(can not access to checked true or false) the don't use %APPDATA% option by default
and now i’m use win 64 OS and installer option don't use %APPDATA% has visible (has access to checked true or false)by default

andrecool-68

Hello everyone!
This option does not work for me (Notepad++ 7.8.1 on x32 and x64 versions)
“Use Monospaced font in Find dialog (Need to restart Notepad++)”

Imgur

dinkumoil

@andrecool-68 , @donho

The real problem is that the setting seems not to be stored in the settings file.

Steps to reproduce

Start Notepad++
As the first step open Preferences dialog and activate option Use Monospaced font in Find dialog.
After that you can open Find dialog and you will see that the text in the input field is displayed with a monospaced font.
Close Notepad++.
Reopen Notepad++ and go to Preferences dialog to check option Use Monospaced font in Find dialog. The option will be unchecked and the text in the input field of the Find dialog will be displayed with a proportional font.

dinkumoil

Continuation

The setting gets stored in the settings file but IMO the code to restore the setting at program startup is wrong.

It could be related to this piece of code

if (optNameMonoFont && !lstrcmp(optNameMonoFont, TEXT("no"))) 
  _nppGUI._monospacedFontFinfDlg = false;

and this one

bool _monospacedFontFinfDlg = false;

IMO the first block should be

if (optNameMonoFont && !lstrcmp(optNameMonoFont, TEXT("yes"))) 
  _nppGUI._monospacedFontFinfDlg = true;

to apply the setting’s data from the settings file and to keep the option off as default.

donho

@gurikbal-singh said in Notepad++ 7.8.1 Release Candidate:

@gurikbal-singh said in Notepad++ 7.8.1 Release Candidate:

hi i was on win 32 OS where installer has invisible(can not access to checked true or false) the don't use %APPDATA% option by default
and now i’m use win 64 OS and installer option don't use %APPDATA% has visible (has access to checked true or false)by default

I don’t think it’s a regression, but it’s a bug for sure.
Could you create an issue on Notepad++ GitHub issues tracker ?
https://github.com/notepad-plus-plus/notepad-plus-plus/issues

donho

@dinkumoil said in Notepad++ 7.8.1 Release Candidate:

@andrecool-68 , @donho

The real problem is that the setting seems not to be stored in the settings file.

Steps to reproduce

Start Notepad++

As the first step open Preferences dialog and activate option Use Monospaced font in Find dialog.

After that you can open Find dialog and you will see that the text in the input field is displayed with a monospaced font.

Close Notepad++.

Reopen Notepad++ and go to Preferences dialog to check option Use Monospaced font in Find dialog. The option will be unchecked and the text in the input field of the Find dialog will be displayed with a proportional font.

Thank you for heads up. The fix will be included in the new release:
https://github.com/notepad-plus-plus/notepad-plus-plus/commit/8e7830795147109fa71059e628c5ff8fbb1a9afd

Zsolt Kántor

If you select None for Folder Margin Style in the Find result list the left margin contains uppercase characters. It would be a good idea to keep margin style even if folder margin style is disabled for the main window? Screenshot below:

donho

@Zsolt-Kántor said in Notepad++ 7.8.1 Release Candidate:

If you select None for Folder Margin Style in the Find result list the left margin contains uppercase characters. It would be a good idea to keep margin style even if folder margin style is disabled for the main window? Screenshot below:

Please keep this thread for “regression” & “critical bugs” only.

For the rest, please report here:
https://github.com/notepad-plus-plus/notepad-plus-plus/issues

donho

@andrecool-68

Fixed:
https://github.com/notepad-plus-plus/notepad-plus-plus/commit/b96f91c39a0f5e9f677e07e29154620b46f8262b