Notepad++ v8 Release Candidate

Michael Vincent · May 20, 2021, 11:57 AM

@Alan-Kilborn said in Notepad++ v8 Release Candidate:

But I’d like to point out that it appears that for a “saved” file that the decision was made to have no icon at all (because it is so glaringly absent that no one would release software that way), in “dark mode” anyway.
Can @donho confirm this? If this truly is a design decision, let’s get it out there and known about, because probably hundreds of users will report it as a bug (“where’s the icon on a saved file’s tab??”).
I kind of like the cleaner look of saved files having no icon (we really only need to see the “exceptional” situations, e.g. modified, locked), but if one switches back to non-dark mode the icon comes back in that case.

I did not know that - but if that’s the case - that certainly makes sense. I am used to seeing the alternate icon green check on saved files. If the above is true, I’m not sure my claims of a “bug” are true then. Seems the “Saved” icon just doesn’t show anymore in Dark Mode - just something I’ll have to get used to ;-)

Cheers.

Michael Vincent · May 20, 2021, 3:21 PM

@Alan-Kilborn said in Notepad++ v8 Release Candidate:

Minor comment on the addition of dark mode: My first instinct is to go to Style Configurator to turn it on/off, not to a Preference page with a single item on it.

Good point - I find myself doing that too!

donho · May 20, 2021, 7:51 PM

@Alan-Kilborn said in Notepad++ v8 Release Candidate:

But I’d like to point out that it appears that for a “saved” file that the decision was made to have no icon at all (because it is so glaringly absent that no one would release software that way), in “dark mode” anyway.

The Fluent UI icons are not made by me but by WildByDesign . So it’s his idea/intention, and I think it’s a good idea.

@Michael-Vincent
The bug’s been fixed : https://github.com/notepad-plus-plus/notepad-plus-plus/commit/156bde258ff16c7c3973874ee7302a568db109ac

donho · May 22, 2021, 10:10 AM

@dinkumoil said in Notepad++ v8 Release Candidate:

Dark mode is not really dark and plugin toolbar icons are missing:

It’s been fixed and merged into master:
https://github.com/notepad-plus-plus/notepad-plus-plus/commit/9a2dcaa5f8eb678e2b0c6494c16a8b9df37f06bb

The most of plugins need to be updated for passing the handle of ICO via hToolbarIcon instead of NULL.

xomx · May 25, 2021, 2:23 PM

I have also tried it on Win8.1 (the n++ Dark Mode looks good there), but after running n++ for a while (on the background with no user activity, just started the portable fresh n++ 8RC with the DarkMode & FluentUI icons on, nothing more), I have repeatedly obtained crash with the exception code 0xC000041d, which means STATUS_FATAL_USER_CALLBACK_EXCEPTION.

I do not have relevant PDB files, so I am only appending screenshot from MSVS how it looks like.

donho · May 26, 2021, 9:41 PM

@xomx said in Notepad++ v8 Release Candidate:

I have repeatedly obtained crash with the exception code 0xC000041d, which means STATUS_FATAL_USER_CALLBACK_EXCEPTION.

Can you reproduce it easily?
Or rather: did it happen again? ie. twice or more times.
Could you provide the debug info?
I can provide a debug binary for the examination if you can reproduce the bug steadily. 32 or 64 build do you need?

xomx · May 27, 2021, 7:44 AM

Yes, I have tried it 4 times in a row with the same result:

download and run the portable v8RC http://download.notepad-plus-plus.org/repository/8.x/8.0.RC/npp.8.0.portable.x64.7z
open n++, set Dark Mode, restart n++ and just minimize it to give it the time to crash
Unhandled exception at 0x0000000000000000 in notepad++.exe: 0xC000041D

Notepad++ v8 (64-bit)
Build time : May 18 2021 - 22:46:05
Path : C:\Notepad++\notepad++.exe
Command Line :
Admin mode : OFF
Local Conf mode : ON
Cloud Config : OFF
OS Name : Windows 8.1 Enterprise (64-bit)
OS Build : 9600.20018
Current ANSI codepage : 1250
Plugins : mimeTools.dll NppConverter.dll NppExport.dll

I can try the debug set with the pdf-files, 64-bit.

donho · May 27, 2021, 10:35 AM

@xomx
Thank you!

Here you can download Notepad++ x64 debug mode binary and its pdb file:
http://download.notepad-plus-plus.org/repository/MISC/npp64DebugBinPdb.zip

I also created an issue regarding the crash and ping the dark mode author:
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/9911

If you can provide info about crash, I can fix it without problem normally.

donho · May 27, 2021, 4:53 PM

@xomx
I have installed VS on my Surface 1, reproduced the crash and did some debug sessions. I believe the crash is fixed in the following binary:
http://download.notepad-plus-plus.org/repository/MISC/npp64DebugPdb2.zip

It’s x64 debug mode notepad++.exe with its PDB file.
Please let me know if the crash is fixed.

donho · May 27, 2021, 8:28 PM

RC2 is available in:
https://community.notepad-plus-plus.org/topic/21228/notepad-v8-release-candidate-2

Let’s talk there.