Daily WTF

donho

Return value

Type: UINT
If the specified item does not exist, the return value is -1.

Ref:
https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getmenustate#return-value

Ekopalypse

@donho

hahahaha

Ekopalypse

but I also like this one very much

donho

@ekopalypse
Hehe, you passed there before I did.

As a result, that’s my only solution:
https://github.com/notepad-plus-plus/notepad-plus-plus/commit/94154b0f0e281b4bbfad9c59f8d01c9dff305c12#diff-ea60a18644324fe9be5958a9435c911ba104980e68482bdab1037a3c134c18c9R107

Ekopalypse

@donho

With me it’s a bit different - I ignored it, so I didn’t implement it :-) … until now, anyway.

mere-human

Jokes aside, this is expected to be UINT_MAX.
See my comment for more info https://github.com/notepad-plus-plus/notepad-plus-plus/commit/94154b0f0e281b4bbfad9c59f8d01c9dff305c12#commitcomment-66609009

Erez Wanderman

Why like this glibc???

ThosRTanner

While looking at the win32 xml APIs, I found https://learn.microsoft.com/en-us/previous-versions/windows/desktop/ms762722(v=vs.85)

Specifically the C API here:

HRESULT load(  
    VARIANT xmlSource,  
    VARIANT_BOOL *isSuccessful);

where

Parameters

xmlSource[in]
An indicator of the source XML to parse. This may be an URL (String/BSTR), a Request object (in an ASP page), an IStream, SAFEARRAY of bytes (VT_ARRAY|VT_UI1), a DOMDocument object, or any object that supports IStream, ISequentialStream, or IPersistStream. See Remarks for more information.

isSuccessful[out, retval]
True if the load succeeded; False if the load failed.

Return Values

S_OK
The value returned if successful.

S_FALSE
The value returned if the load fails.

E_INVALIDARG
The value returned if the isSuccessful parameter is Null.

So you have to pass a pointer to a bool to hold more or less the same information as the return value of the function, and if you pass a null pointer, you get your hand spanked…