Notepad++ v8.4.6 Release Candidate 2

donho

Notepad++ v8.4.6 Release Candidate 2:
http://download.notepad-plus-plus.org/repository/8.x/8.4.6.RC2/

Fix from Notepad++ v8.4.6 RC:

Fix Change History margin visual glichy under dark mode.

Notepad++ v8.4.6 bug/regression-fixes and new features:

Add Change History markers for document saved/unsaved/undone modification. (Fix #12164, #12046
Add setting tab color ability. (Fix #2271)
Update to Scintilla 5.3.0 and Lexilla 5.1.9 (Implement #12045)
Fix “Never” button not showing on Updater dialog regression. (Implement 9c86a33)
Fix a printing selection regression. (Fix #11826, #12033, #11638)
Revamp tab context menu: make it less cluttered by adding sub-menu. (Fix #12147)
Fix a security vulnerability. (Fix #12113)
Add dark mode support to Choose Color dialog. (Fix #12148)
Add a page (tab) for incompatible (unloaded) plugins in Plugin Admin. (Fix #12069)
Add Plugin list repository link and its version in PluginAdmin dialog.
Fix horizontal bar showing issue while resizing document list’s height. (Fix #12191)
Fix NPPN_DARKMODECHANGED wrong return value to plugins. (Fix #12144)

Yaron

Scintilla 5.3.0: “URL Hovered” only affects links’ underline.

guy038

Hello, @don-ho and All,

Sorry to be a spoilsport, but playing around with the new tab color feature ( thanks for that ! ), I noticed, for instance, that the difference between color 1 and color 4 are really tiny, when not in Dark mode !

So, in a future release, could you add, in the Style configurator, for the Global Styles language, the 5 styles :

Tab Style 1
Tab Style 2
Tab Style 3
Tab Style 4
Tab Style 5

which would allow, each of us, to easily modify these colors ?

Now, regarding the possibility to define a tab color for all the files with a specific extension, while not adding, in Preferences > Highlighting, a new group :

------ Tab Matching Extensions ------

Tab color 1 and a zone to type in an extension
Tab color 2 and a zone to type in an extension
Tab color 3 and a zone to type in an extension
Tab color 4 and a zone to type in an extension
Tab color 5 and a zone to type in an extension

Of course :

Any assignment of an extension would force all the tabs, with that specific extension, to be colored with the chosen color, regardless of their possible previous color
Any deletion of an extension would break, from now on, the link between that extension and the specified tab color and this color would be removed for all the tabs with the specified extension

As usual, @don-ho, there are only suggestions. Take your time ! It’s just up to you to consider, or not, part or all of these ideas !

Best Regards,

guy038

Alan Kilborn

@guy038

As this thread is supposed to be reserved for any CRITICAL PROBLEMS found with the RELEASE CANDIDATE, I have moved your discussion to a NEW THREAD.

donho

@guy038

I noticed, for instance, that the difference between color 1 and color 4 are really tiny

Yes indeed. I have the same feeling about that.
Since it’s also bothering me, I did the modification on the 1st and the 4th color here:

For your feature request, I was thinking about it, but it’s not that easy - you’re always welcome to create the FR on github.

@Alan-Kilborn said in Notepad++ v8.4.6 Release Candidate 2:

As this thread is supposed to be reserved for any CRITICAL PROBLEMS found with the RELEASE CANDIDATE, I have moved your discussion to a NEW THREAD.

I really think it’s OK to talk about new added feature here. For example in this feature the colors are fixed, and I don’t see the way (yet) to make it customizable. Such alert could redirect the new feature - in this case, I will try to make the colors more distinguishable before the release to the public.

guy038

Hi, @don-ho and All,

As requested :

https://github.com/notepad-plus-plus/notepad-plus-plus/issues/12223

BR

guy038

donho

I will try to make the colors more distinguishable before the release to the public.

Regarding this point, could you guys test the binary here:
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/12224

And please let me know your thoughts.
Thank you

guy038

Hello, @Don-ho,

You said :

Regarding this point, could you guys test the binary here:
https://github.com/notepad-plus-plus/notepad-plus-plus/pull/12224

I personally do not see any reference to a binary file ?

May be I miss something obvious as I’m not very acquainted to GitHub functionalities !

Best Regards,

guy038

Alan Kilborn

@guy038 said in Notepad++ v8.4.6 Release Candidate 2:

do not see any reference to a binary file ?
May be I miss something obvious as I’m not very acquainted to GitHub functionalities !

How to test a PR’s binary is described HERE on the (github) Notepad++ site, and @Yaron gets even more specific about it HERE.

Andi Kiissel

@donho
Colors OK
Kind of weird that tab color is saved in the sessions.xml but not in the MRU history in the config.xml

Alan Kilborn

@Andi-Kiissel said in Notepad++ v8.4.6 Release Candidate 2:

Kind of weird that tab color is not (saved) in the MRU history in the config.xml

What does this mean? You expect that if a tab has been colored and then the tab is closed by the user and reopened, it should restore the previously set color to the tab? If so, then I think that is not a reasonable expectation. If something different, can you elaborate on what you mean?

Andi Kiissel

@Alan-Kilborn said in Notepad++ v8.4.6 Release Candidate 2:

I think that is not a reasonable expectation

I think that is a reasonable expectation. People think differently. Sorry.

Alan Kilborn

@Andi-Kiissel said in Notepad++ v8.4.6 Release Candidate 2:

I think that is a reasonable expectation. People think differently. Sorry.

But it is not the Notepad++ expectation. When a file is closed these things, for example are not remembered as well if the file is reopened:

encoding previously set (not autodetected)
bookmarks
caret position
selection made (if any)
styling (1-5) that had previously been done
mark styling from Mark
etc.

So, remembering tab color for a previously opened but now closed tab is NOT reasonable. You can disagree, but this will never be something done by Notepad++.

guy038

Hi, @don-ho and all,

Thanks Don for finding a nice set of five tab colors ! I would say that this new group of colors does not make their modifications, via the Style configurator, so urgent !

And thanks to @Yaron and @alan-kilborn for providing their GitHub information to me :-))

Now, as @Andi-Kiissel spoke about the MRU history feature ( Ctrl + Tab ) with @alan-kilborn, I noticed a weird behaviour :

Open the View > Document List panel
Then, open the Settings > preferences... > General panel
Tick, then untick the Alternate icons option in the Tab Bar section

=> The icons in the Document List panel change accordingly, as expected !

But, if you use the Ctrl + Tab shortcut, the MRU list always displays the old “floppy” icon ( in blue, red or grey color ) !

Not critical, of course, but I’m personally got used to the alternate icons which are more easy to distinguish and should be the default set, to my mind !

Best Regards,

guy038

P.S. :

So, here is the way I understand the method to test a new build of N++ :

Click on the “https://github.com/notepad-plus-plus/notepad-plus-plus/pull/Number” link, provided by @don-ho or an other contributor

=> A new GitHub window opens

At right of a line, below, containing the modifications, click on the green check mark ( Not on the last hexadecimal number ! )
On the small windows, which pops up, click on the blue link Details
On a new Appveyor window, click, either, on the job name :
- Environment: compiler=MSC, platform=Win32; Configuration: Debug
- Environment: compiler=MSC, platform=x64; Configuration: Debug
On the new Appveyor window which opens , click on the Artifact tab
Click on the blue link Notepad++.win32.Debug.exe or Notepad++.x64.Debug.exe

=> The corresponding file should be downloaded on your laptop !

Alan Kilborn

@guy038 said in Notepad++ v8.4.6 Release Candidate 2:

the MRU list always displays the old “floppy” icon ( in blue, red or grey color ) !

Not a new feature, and not a regression with 8.4.6RC, so…I think you need to create a new issue about it.

guy038

Hi, @alan-kilborn and All,

As requested :

https://github.com/notepad-plus-plus/notepad-plus-plus/issues/12242

BR

guy038

donho

Please check Notepad++ v8.4.6 RC3:
https://community.notepad-plus-plus.org/topic/23524/notepad-v8-4-6-release-candidate-3