Notepad++ v8.4.6 Release

Alan Kilborn

One may wonder why the Display Change History setting is on the Margins/Border/Edge subpage rather than the Editing subpage. Well, the answer is simple; the history is shown in a “margin” on the left side of the editing window.

Michael Vincent

@Alan-Kilborn said in Notepad++ v8.4.6 Release:

One may wonder why the Display Change History setting is on the Margins/Border/Edge subpage rather than the Editing subpage. Well, the answer is simple; the history is shown in a “margin” on the left side of the editing window.

They may be looking at the image in the issue that’s linked to Change History and since it was my image, I’ve updated my comments to put some context before the image:

(the below is NOT an actual screenshot, but a created image to show a concept - this is not in the real Preferences dialog window)

Hopefully that will clear it up though I’m sure people see the pretty picture and ignore the words just before it!

Cheers.

Alan Kilborn

Also, and sorry to continue polluting this thread with non-criticial-problem stuff, but… LISTEN UP PEOPLE: DON’T BE TOO HASTY WITH WANTING TO TURN OFF CHANGE HISTORY! We know you hate any kind of change and just scream for your old functionality back, but this is a killer feature, at least give it a chance!

Alan Kilborn

@Alan-Kilborn said in Notepad++ v8.4.6 Release:

One may wonder why the Display Change History setting is on the Margins/Border/Edge subpage rather than the Editing subpage. Well, the answer is simple; the history is shown in a “margin” on the left side of the editing window.

@donho Does the UI on the Margins/Border/Edge subpage need a slight adjustment?:

Display Change History Margin
Display Bookmark Margin
Line Number Margin

Again, apologies as this is not critical…

donho

@Alan-Kilborn said in Notepad++ v8.4.6 Release:

Does the UI on the Margins/Border/Edge subpage need a slight adjustment?:

The fact of these settings being in the subpage implies they are margins, so it’s not necessary IMO.

Iton Horn

Hello, dear Notepad++ Community,

if Notepad++ v. 8.4.6 is started using command line “-openSession” switch with BookmarksDook (2.3.3) plugin, it display bookmarks to the left of the text but does not display bookmarks in the plugin window. The session files are created with Notepad++ v. 8.4.5. Previous installation, the Notepad++ v. 8.4.5 displays bookmarks from the same session files properly.

Please check this.

Thank you.

Debug information:
Notepad++ v8.4.6 (32-bit)
Build time : Sep 25 2022 - 19:55:26
Path : C:…\Notepad++\notepad++.exe
Command Line :
Admin mode : OFF
Local Conf mode : ON
Cloud Config : OFF
OS Name : Windows 10 Enterprise (64-bit)
OS Version : 21H1
OS Build : 19043.2006
Current ANSI codepage : 1251
Plugins :
BookmarksDook (2.3.3)
ComparePlugin (2.0.2)

ImSpecial

@guy038
Very easy indeed, thanks!

@Michael-Vincent
TBH it was 3AM my time, so those “concept” words you added could’ve been giant siren lights and I still would’ve missed it. Pretty pictures are king unfortunately. :)

My suggestion for the “change history” is maybe add a quick toggle for it somewhere around here;
https://i.imgur.com/ZQK8SlG.png

Like I don’t hate it, and could find it useful on occasions, but 90% of the time I wouldn’t need it, and so it’s distracting more then not in my case.

Noticed that it also require a reboot when changing on/off, so maybe a toolbar toggle is out of the question either way.

PeterJones

@ImSpecial said in Notepad++ v8.4.6 Release:

Noticed that it also require a reboot when changing on/off

Exiting and reloading Notepad++ is sufficient. You do not have to do a full reboot of the OS/PC.

And you can turn off the feature without a restart; you only need to restart Notepad++ when you toggle it from off back to on.

Bas de Reuver

I’ve completed the latest CSV Lint 0.4.6 updates just yesterday. Is it possible to still include the latest nppPluginList in this Notepad++ release?

I try to do the plug-in updates in between regular Notepad++ updates so that the Plugins Admin always has the most recent version (doesn’t lag behind too much), but it’s hard to keep it in-sync because Notepad++ doesn’t have a regular release schedule afaik.

Alan Kilborn

@Bas-de-Reuver said in Notepad++ v8.4.6 Release:

Is it possible to still include the latest nppPluginList in this Notepad++ release?

No. Probably should have prepared it during the RC phase, when it had a chance to get it.

Bas de Reuver

@Alan-Kilborn ok I understand, I’ll keep an eye on the Announcements posts more, and try to plan the timing of plugin updates better.

BillDavison

First time posting, but longtime Notepad++ user.

I’m having printing problems that began with the upgrade to 8.4.6. The printed page has black text on a dark grey background, making it almost unreadable. This behavior is also visible in “print preview”. It affects all files, including newly created test files.

Printing returns to normal if I turn off “display change history”.

Debug info below:
Notepad++ v8.4.6 (32-bit)
Build time : Sep 25 2022 - 19:55:26
Path : C:\Program Files (x86)\Notepad++\notepad++.exe
Command Line :
Admin mode : OFF
Local Conf mode : OFF
Cloud Config : OFF
OS Name : Windows 10 Home (64-bit)
OS Version : 21H2
OS Build : 19044.2006
Current ANSI codepage : 1252
Plugins :
DSpellCheck (1.4.21)
Explorer (1.9.4)
JSMinNPP (1.2006)
mimeTools (2.8)
NppConverter (4.4)
NppExport (0.4)

mattesh

@donho @Iton-Horn
I can confirm, something is broken.
See comparing results with my AnalysePlugin
https://sourceforge.net/p/analyseplugin/bugs/92/

reason is that with commit 9455684b429449f668c1aedb77ec9dcb1642c244
the value of the blue circle bookmark did change

-const int MARK_BOOKMARK = 24;
...
+const int MARK_BOOKMARK = 20;

But this constant value is part of the Bookmark interface used in SCI_MARKERADD message.

Proposal would be to change back the number, so that plugins can maintain using the blue bookmark as before.

please, comment

Michael Vincent

@mattesh said in Notepad++ v8.4.6 Release:

Proposal would be to change back the number, so that plugins can maintain using the blue bookmark as before.
please, comment

Not going to happen. Plugins will need to adjust. The bookmark value needed to be changed to accommodate for change history feature from scintilla which uses that marker number (24).

Cheers.

donho

@mattesh @Iton-Horn

reason is that with commit 9455684b429449f668c1aedb77ec9dcb1642c244
the value of the blue circle bookmark did change
But this constant value is part of the Bookmark interface used in SCI_MARKERADD message.

Proposal would be to change back the number, so that plugins can maintain using the blue bookmark as before.

Plugin authors should use NPPM_ALLOCATEMARKER to allocate marker ID, instead of using hard coded value:
https://github.com/notepad-plus-plus/notepad-plus-plus/blob/master/PowerEditor/src/MISC/PluginsManager/Notepad_plus_msgs.h#L368

Here is its usage:


int newId = 0;
BOOL isOK = ::SendMessage(nppHandle, NPPM_ALLOCATEMARKER, 3, (LPARAM) &newId);

// If the value of isOK is true, you allocate your marker IDs successfully.
// Let's say newId is 4, so 4 is your marker start ID, and you have allocated 3 markers - 4, 5, 6 are the 3 IDs reserved in Notepad++ for your plugin.

Alan Kilborn

@donho said in Notepad++ v8.4.6 Release:

Plugin authors should use NPPM_ALLOCATEMARKER to allocate marker ID, instead of using hard coded value

That is good advice, but only for plugins creating something new. The reference here, as far as I can tell, is to the BookmarkDook plugin, which needs to use the same marker Notepad++ uses for (existing) bookmarks. As that is changed, the BookmarkDook plugin author will have to change as well.

donho

@Alan-Kilborn

That is good advice, but only for plugins creating something new. The reference here, as far as I can tell, is to the BookmarkDook plugin, which needs to use the same marker Notepad++ uses for (existing) bookmarks. As that is changed, the BookmarkDook plugin author will have to change as well.

So in this case, a new API NPPM_GETBOOKMARKMARGINID will be made for plugins which use Bookmark Margin.

donho

@Alan-Kilborn said in Notepad++ v8.4.6 Release:

That is good advice, but only for plugins creating something new. The reference here, as far as I can tell, is to the BookmarkDook plugin, which needs to use the same marker Notepad++ uses for (existing) bookmarks. As that is changed, the BookmarkDook plugin author will have to change as well.

However, I’ve just checked the ID of bookmark margin, there’s no change (_SC_MARGE_SYMBOL):
https://github.com/notepad-plus-plus/notepad-plus-plus/commit/fc32fbdcce371bb669c9361d62c959b1b61e33f0#diff-d88ddee57a027ab23daf332c4778ced0cee352edcb34efdda1b218e8a75c61b2

Alan Kilborn

@donho said in Notepad++ v8.4.6 Release:

However, I’ve just checked the ID of bookmark margin, there’s no change

It isn’t the margin id, it’s the marker id.
It used to be 24, now it is 20.
@mattesh discussed this, above.

donho

@Alan-Kilborn
Thank you for pointing out the real problem.

NPPM_GETBOOKMARKID has been add in the master:
https://github.com/notepad-plus-plus/notepad-plus-plus/commit/4d5069280900ee249d358bc2b311bdb4b03f30a9

and the new API will be available in the next release.