Notepad++ v8.6.1 Release Candidate

Andi Kiissel

Fix hidden results of long lines for Search results with “Find in…” commands.

This complex bug is not fully fixed - “Next Search Result” F4 still doesn’t work as it should.

donho

@Artur-Harison

https://github.com/notepad-plus-plus/notepad-plus-plus/pull/14497#issuecomment-1872220382

donho

@Andi-Kiissel said in Notepad++ v8.6.1 Release Candidate:

This complex bug is not fully fixed - “Next Search Result” F4 still doesn’t work as it should.

F4 follows the occurrences displayed in line entry, so there’s no way to fix it.

Andi Kiissel

This complex bug is not fully fixed - “Next Search Result” F4 still doesn’t work as it should.

F4 follows the occurrences displayed in line entry, so there’s no way to fix it.

But Shift-F4 somehow works correctly.
And before v8.4.3 F4 also worked correctly.

Alan Kilborn

I agree with @Andi-Kiissel 's assessment that F4 usage with certain data is critically broken. The type of data is “really long lines” which is difficult data to work with in the first place (due to horizontal scrolling), making it of paramount importance that a feature like F4 correctly walks through all of the matches, one by one. It can be the only way in which a user has confidence that he is seeing all of the matches.

If there are other interested users that want to assess this for themselves (for example, by experimenting with this 8.6.1RC), a starting point is reading through issue 12023.

Manu el

The icons in toolbar for cut and copy always are enabled. It makes no difference whether the text is selected or not.

Alan Kilborn

@Manu-el said in Notepad++ v8.6.1 Release Candidate:

The icons in toolbar for cut and copy always are enabled. It makes no difference whether the text is selected or not.

This is correct behavior.
If there is no selected text, the Copy or Cut commands will consider that the line of the caret is the target text. Thus, there is always something to Copy or Cut. Thus, the commands and icons in the toolbar are always enabled.

donho

FYI: v8.6.1 RC binaries have been updated.

The change log information has been completed in the new binaries.
It included the new tabContextMenu_example.xml file.
The obsolete Scintilla API has been replaced by the new ones.
It included updated localization files which contains the new entries.

Enjoy.

Manu el

@Alan-Kilborn
Ah, I see. I didn’t know it was possible to copy/cut the whole line without selecting it first. I have always used triple-click to select the line and then use the copy/cut command.
Thanks for the clarification.

1709 B

In 8.6.1, I’m experiencing a crash when trying to switch from a custom dark theme (based on Bespin) to DarkModeDefault. Starting with 8.6.0, the DarkModeDefault seems to have invisible secondary carets (only the main caret has the correct forecolor).

donho

@1709-B
Could you provide the step by step instructions here to reproduce the crash?

1709 B

@donho said in Notepad++ v8.6.1 Release Candidate:

@1709-B
Could you provide the step by step instructions here to reproduce the crash?

I can work-around it by creating an exact copy “c:\Program Files (x86)\Notepad++\themes\DarkModeDefaultCopy.xml” (switching to this works, doesn’t for DarkModeDefault), but here are the original steps:

Start with NPP 8.6.0.
Change the theme to DarkModeDefault and change some options like fonts in Global Override and Default.
Change the theme to Bespin.
Upgrade to NPP 8.6.1.
Switch to DarkModeDefault.

=> Crash, with below in event log:
Faulting application name: notepad++.exe, version: 8.6.1.0, time stamp: 0x658f8135
Faulting module name: notepad++.exe, version: 8.6.1.0, time stamp: 0x658f8135
Exception code: 0xc0000409
Fault offset: 0x0034d6b6
Faulting process id: 0x0x6034
Faulting application start time: 0x0x1DA3E018485F9C7
Faulting application path: C:\Program Files (x86)\Notepad++\notepad++.exe
Faulting module path: C:\Program Files (x86)\Notepad++\notepad++.exe
Report Id: 3fff680f-4905-4f21-90c5-ceda06adb6d8
Faulting package full name:
Faulting package-relative application ID:

1709 B

Another issue that might be 8.6.1 specific (were move commands previously mapped directly to Scintilla commands?):

Start with a sample multiline text:
abc123

def456
Multi-select just the numbers, e.g. sel “123” then CTRL+sel “456”.
Press ALT+Down or ALT+Up, mapped to Move commands in main menu.

=> Current line is moved correctly, but the secondary selection is unexpectedly deleted, e.g. “123”. Expected would be either that both lines are moved (like in Sublime and VSCode), or at least that the main menu move commands first clear secondary carets/selections, then move the current line.

1709 B

This is not 8.6.1 specific, but is it possible to fully disable change history? I have unchecked Display Change History and unchecked Display Bookmarks, but I still see the colored recently changed lines, like in…

![https://user-images.githubusercontent.com/58158242/197697304-9f6ab210-a301-479e-92f2-bd984e071f3a.png](image url)

xomx

@1709-B said in Notepad++ v8.6.1 Release Candidate:

Start with NPP 8.6.0.
Change the theme to DarkModeDefault and change some options like fonts in Global Override and Default.
Change the theme to Bespin.
Upgrade to NPP 8.6.1.
Switch to DarkModeDefault.

=> Crash, with below in event log:

Cannot reproduce.
I tried both with the installed N++ and with the portable v8.6.0 & v8.6.1rc.

Exception code: 0xc0000409

Maybe some of your installed N++ files are corrupted.

Exact exception description is the STATUS_STACK_BUFFER_OVERRUN but it is probably a manifestation of the user mode STATUS_FAIL_FAST_EXCEPTION (the 0xc0000409 used to be used to indicate that the user mode callstack had a buffer overrun, corrupting the stack and potentially opening up the app to a malicious attack, but now this exception code has been repurposed for all the fast-fail stuff). If this is the case, your first exception parameter recorded should define the exact reason - here is the list of all possibilities:
https://github.com/wine-mirror/wine/blob/a2f98478c36908fd7a368cc633b6064aca053ab6/include/winnt.h#L961-L1031

You can try testing again without your plugins or using a fresh N++ portable versions instead.

donho

@Andi-Kiissel said in Notepad++ v8.6.1 Release Candidate:

This complex bug is not fully fixed - “Next Search Result” F4 still doesn’t work as it should.

F4 follows the occurrences displayed in line entry, so there’s no way to fix it.

But Shift-F4 somehow works correctly.
And before v8.4.3 F4 also worked correctly.

Fixed in https://github.com/notepad-plus-plus/notepad-plus-plus/pull/14544
Please confirm me it does fix your issue.

Andi Kiissel

@donho
Yes, the F4 bug with long lines is now fixed. Thank you!

donho

FYI, v8.6.1 RC binaries have been updated.
2 bug-fixes: