• Login
Community
  • Login

Link underlines no longer auto-applied on search/replace

Scheduled Pinned Locked Moved General Discussion
8 Posts 4 Posters 533 Views
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • M
    mkupper
    last edited by Mar 13, 2024, 8:30 PM

    I was using v8.6.4 and had

    xyzzy
    

    I did a search/replace:
    Search: ^xyzzy
    Replace: https://notepad-plus-plus.org/

    https://notepad-plus-plus.org/ appeared but it was not underlined and was not clickable. If you then scroll the page or make any changes then https://notepad-plus-plus.org/ gets underlined and is clickable.

    With Notepad++ v8.6.2 and earlier the link was underlined immediately after the search/replace. A change related to v8.6.3 RC1 broke this.

    The exact search/replace does not matter as long as it’s one that creates a file:// or https?:// style string of text that is normally underlined and clickable.

    P M 2 Replies Last reply Mar 13, 2024, 8:43 PM Reply Quote 1
    • P
      PeterJones @mkupper
      last edited by Mar 13, 2024, 8:43 PM

      @mkupper ,

      I see the same change in behavior. My guess is that the v8.6.3 removed a screen-redraw after the search

      If you are looking for a workaround: In my scripts, I often use notepad.activateFile(notepad.getCurrentFilename()) to force a GUI Redraw. You could probably find an appropriate NOTIFICATION callback to trigger said redraw after running a search/replace (maybe SCINTILLANOTIFICATION.MODIFIED)

      M 1 Reply Last reply Mar 13, 2024, 10:56 PM Reply Quote 2
      • M
        Mark Olson @PeterJones
        last edited by Mark Olson Mar 13, 2024, 10:57 PM Mar 13, 2024, 10:56 PM

        @PeterJones said in Link underlines no longer auto-applied on search/replace:

        You could probably find an appropriate NOTIFICATION callback to trigger said redraw after running a search/replace (maybe SCINTILLANOTIFICATION.MODIFIED)

        I suspect that the very reason this broke is that Don Ho turned off a bunch of SCN_MODIFIED notifications during find/replace actions in this PR between 8.6.2 and 8.6.3 . Assuming my hypothesis is correct, the fix (within Notepad++) is to make sure that the screen-redrawing callback fires in response to the NPPN_GLOBALMODIFIED notification .

        M 1 Reply Last reply Mar 15, 2024, 4:27 PM Reply Quote 3
        • M
          mkupper @Mark Olson
          last edited by mkupper Mar 15, 2024, 5:06 PM Mar 15, 2024, 4:27 PM

          Thank you @PeterJones and @Mark-Olson. I have added As of v8.6.3 a search/replace that results in a link no longer gets auto-underlined to to github.

          R 1 Reply Last reply Mar 15, 2024, 4:51 PM Reply Quote 0
          • R
            rdipardo @mkupper
            last edited by Mar 15, 2024, 4:51 PM

            @mkupper said in Link underlines no longer auto-applied on search/replace:

            I have added [As of v8.6.3 a search/replace that results in a link no longer gets auto-underlined](https://github.com/notepad-plus-plus/notepad-plus-plus/pull/14685)

            Can you try editing the pull path segment to issues (with an s)? GitHub is strangely redirecting your issue’s link to an unrelated pull request; note the “location” header field below:

            $ curl -I https://github.com/notepad-plus-plus/notepad-plus-plus/issues/14685
            HTTP/2 302 
            server: GitHub.com
            date: Fri, 15 Mar 2024 16:46:42 GMT
            content-length: 0
            location: https://github.com/notepad-plus-plus/notepad-plus-plus/pull/14685
            server-timing: nginx;desc="NGINX";dur=1.25579,glb;desc="GLB";dur=4.836778
            x-voltron-version: 6f4c7bf
            vary: Accept-Encoding, Accept, X-Requested-With
            x-frame-options: DENY
            set-cookie: _gh_sess=wtG2i1IYZskKkbI56Z7Jrg377SDAjuUsuai%2Bt66MYWTzaZAkYxXIYJAQZSx7IUqXre%2FYUNkPZCaZNaGaUYP1YSk1A65nuKXTu9TWzvO7YJwqP%2BTsu0penyKEblb0doN2Ef4OYL%2Fi04JZU52N3ENXHWCSG3SirMw9Qp44TBDfnnD74TfNtT1U6aWerGeeg%2FXvhFp72FOSfYQckYlKBX4VKmL340ftu5hrdVxX1Bg1I0hUwv61%2BhCs%2Bch1YieXhr1q%2FrIqWrTQzHFS7pKOz%2F03Zw%3D%3D--WZv5roxfzR1VMoSL--XA3jbofSbpJoAJt3vWw07w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
            set-cookie: _octo=GH1.1.899969362.1710521202; Path=/; Domain=github.com; Expires=Sat, 15 Mar 2025 16:46:42 GMT; Secure; SameSite=Lax
            set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 15 Mar 2025 16:46:42 GMT; HttpOnly; Secure; SameSite=Lax
            x-github-request-id: C7E0:6910:11CA684:1A33093:65F47B72
            
            R 1 Reply Last reply Mar 15, 2024, 5:04 PM Reply Quote 0
            • R
              rdipardo @rdipardo
              last edited by Mar 15, 2024, 5:04 PM

              I said in Link underlines no longer auto-applied on search/replace:

              Can you try editing the pull path segment to issues …?

              On second thought, it would be better to close #14685 and create a new issue with the same content. GitHub’s API is never supposed to reuse an item id number, but somehow you created a issue with the same id as an older pull request…!

              M 1 Reply Last reply Mar 15, 2024, 5:14 PM Reply Quote 0
              • M
                mkupper @rdipardo
                last edited by Mar 15, 2024, 5:14 PM

                @rdipardo said in Link underlines no longer auto-applied on search/replace:

                I said in Link underlines no longer auto-applied on search/replace:

                Can you try editing the pull path segment to issues …?

                On second thought, it would be better to close #14685 and create a new issue with the same content. GitHub’s API is never supposed to reuse an item id number, but somehow you created a issue with the same id as an older pull request…!

                Sorry, when I was constructing the link for this forum thread I grabbed the URL of a PR and not the issue I had just added. I have edited my earlier post to correctly point to issue #14864. Github was fine.

                1 Reply Last reply Reply Quote 1
                • M mkupper referenced this topic on Mar 15, 2024, 5:14 PM
                • M
                  mkupper @mkupper
                  last edited by Mar 19, 2024, 11:51 PM

                  This issue has been fixed via this commit which also fixes github issue 13916 .

                  For those interested in trying the Notepad++.exe go to https://github.com/molsonkiko/notepad-plus-plus/actions/runs/8351086718 and download either Notepad++.MSVC.Win32.Release or Notepad++.MSVC.x64.Release. You will get a zip file that you can drop on top of the portable or installed version of Notepad++ you want to test with.

                  The coding changes for 13916 appear non-trivial and so I doubt @donho will pull them into v8.6.5 which is already in the release candidate state.

                  1 Reply Last reply Reply Quote 1
                  6 out of 8
                  • First post
                    6/8
                    Last post
                  The Community of users of the Notepad++ text editor.
                  Powered by NodeBB | Contributors