Find & Replace & Mark re-organization proposal

David Brigden52

Thanks for info and I think we can all agree that the monstrosity should only be seen on the first of April, if THEN.

I’ve read issue 16229 and it was quite informative. I may have at one time been aware of the search settings in preferences, and the arrow to switch between compact and extended view. But I had forgotten all that.

I was NOT aware of the selection checkbox, which started the whole thing, even though it’s in front of me every time I do a search or replace. It’s a sign of my not using the feature. but now that I see it, I have opinions

Inside selection is kind of meaningless if I’m searching all opened documents or within files. Rather than a separate dimension, I think it should be part of the hierarchy of search scope: Find, Find All in Selection, Find All in Document, Find All in All Opened Documents etc.

@shodanx2
Thanks, the dark mode was difficult to make out on a smaller screen. and thanks for a list of things

In Selection Toggle: as noted above, I don’t like the way it is currently implemented. and an auto toggle seems confusing.
Find / Replace / Mark Tabs: Honestly, this doesn’t bother me here. In general, I think I lean towards liking a tabbed interface
Input Copy/Swap Function: I so rarely swap and never copy, that having a drop down doesn’t bother me. I’m neutral on this sort of change
Wider Search and Replace fields: I am not hampered by the size right now. If we could rearrange and make larger, great! If not, great!
Transparency Settings: If I had single monitor and my search window was over the editor I’d make use of this. I don’t see a need to keep it. If we could use that space for something else, fine.
Split Find Next Toggle: meh. It it were up to me, I’d make the the bidirectional buttons the only option, or at least move the choice to Preferences.
Live Counts: I Like putting the counts in the text of the buttons. I’m not sure how hard it would be to implement, but pretty
Locking Replace All. No. If we have the option set in Preferences, we’re already confirming the change. that’s just extra room.
Diacritics: Sure if there’s space, why not?

Light Mode: I use a dark theme with my light Mode, so dialogs are a nice gentle gray, not blazing white.

Smaller Learning Curve:
I really don’t think so. There’s a lot on that screen that I don’t want or need to know. which brings me to

It’s too cluttered. A row of buttons on the right became a larger grid of buttons, but mostly, the icons

You’ve got two sets of icons in two different layouts and sizes. The search dialog is dominated by the icon grid on the left.

There are circumstances where icons are the best GUI element (toolbars) or are best in combination with text (the tabs in Notepad++ for example) But in a number of the cases you described, I think the best element would be a checkbox with explanatory text.

shodanx2

@PeterJones said:
The search engine can only run one search at a time, so every time I updated the regex, it would have to wait minutes to update the “live” count(s) before I could run the replacement I wanted. No thank you.

I do occasionally open big files, I have one open right now.

That doesn’t seem like much of a problem to me ?

Here is how to do it

Put a filesize guard on the auto-count algorithm, so it just doesn’t fire for files beyond threshold.
Put a throttle delay so it can’t fire again until a delay has passed, I think 100 millisecond / 10 hertz would still feel responsive while leaving ample room from 99% of files to search through.
run the auto-count algorithm in another thread so it doesn’t freeze the UI on especially big files (or, just reduce max file threshold)
don’t trigger auto-count algo until it returned
Give auto-count algo a timeout value
Give user disable auto-count toggle
Manual count trigger by left click window background

I just checked how long the count algo actually takes.

On my 156 megabytes file that is 39 milliseconds.

Let the user fiddle with the values you like, I suggest these default values. Use this layout.

shodanx2

@David-Brigden52 said:

In Selection Toggle: as noted above, I don’t like the way it is currently implemented. and an auto toggle seems confusing.

For me it was brutal, I thought I was going crazy, somehow that toggle was always the opposite of what I needed ! And … it took me a loooooong time to discover that it changes on its own !!

1024 bytes it a selection threshold I am very often on either side of !
I understand the idea, “in selection if it’s big enough” but then you have to keep in mind where that threshold it, but counting 1024 character really is not obvious. I’m not sure if it only enabled but I think it would also disarm when you’re under threshold.

I have PTSD from that damn toggle ! My thousand+ steps windows configuration checklist has a line about disabling this feature. Separate buttons for replace in selection and replace in document solves that problem. Now where you click always does what you want.

Find / Replace / Mark Tabs: Honestly, this doesn’t bother me here. In general, I think I lean towards liking a tabbed interface

As I studied this dialog box, I realize that many many times I would have benefited from the highlight feature, but not if it’s an other tab. I need it but not often enough to remember it exists. Also having multiple highlights with different colour, having those highlights in a list, and preserving those highlight over np++ restarts as permanent highlighting of the text would be really nice.

Input Copy/Swap Function: I so rarely swap and never copy, that having a drop down doesn’t bother me. I’m neutral on this sort of change

I didn’t notice it was there, it was interface noise, I think I might use swap, if I remember it exists. Not a fan at all of a two click operation.

Wider Search and Replace fields: I am not hampered by the size right now. If we could rearrange and make larger, great! If not, great!

I often paste long, really really long searches in there. I’d like to see more of it, I also would like side-scroll to work on this textbox (currently side-scroll does horizontal scroll on it, that’s a bug)

Transparency Settings: If I had single monitor and my search window was over the editor I’d make use of this. I don’t see a need to keep it. If we could use that space for something else, fine.

I have 4x40" monitors

I always leave it translucent and it’s always absolutely all over the place. But I never needed to adjust it after the first time, it belongs in settings, but there should be a gear icon for settings on the search dialog.

Split Find Next Toggle: meh. It it were up to me, I’d make the the bidirectional buttons the only option, or at least move the choice to Preferences.

I don’t see why not always have prev/next, I use both extensively, only reason the toggle is there, in my opinion, is in case someone complains about it, to pre-emptively quiet them. But I don’t think those people really exist. That’s why I call this a vestigial feature.

Live Counts: I Like putting the counts in the text of the buttons. I’m not sure how hard it would be to implement, but pretty

I really would like that, even if it does it 1 per second. Being able to just type and see how many results you got sounds soooo useful. You get an immediate look at what is going on. And with prev count and next count, you kind of can orient with it, like I type a function name, and at a glance I can tell if I’m before of after it.

Locking Replace All. No. If we have the option set in Preferences, we’re already confirming the change. that’s just extra room.

This signals that button is not dangerous. You know how sometimes UI have buttons that if you click them something bad will happen. This happenned to me too often, I have PTSD about it. Even if there’s a guard, it makes me nervous. I have never used it, but I see how it might be useful but I always have a bazillion files open in my session so that button is never safe, even though, I know there’s a guard. But have you even misclicked something and then also bumped space by accident ? That would do it ! Aaaaaahahhhhh !

Light Mode: I use a dark theme with my light Mode, so dialogs are a nice gentle gray, not blazing white.

On my HDR oled monitor, it is so bright it lights up the room.

Smaller Learning Curve:
I really don’t think so. There’s a lot on that screen that I don’t want or need to know. which brings me to

It’s too cluttered. A row of buttons on the right became a larger grid of buttons, but mostly, the icons

Decluttering the layout is easy, just add more layout buttons in settings.

I would like either a “advanced mode” toggle. Or “layout change on resize” where the bigger you make the dialog, the more buttons it adds. What just a find bar, shrink it until that is all there is.

You’ve got two sets of icons in two different layouts and sizes. The search dialog is dominated by the icon grid on the left.

Yes there is many other ways to do this. Once you know what the icons mean, like the regex symbol and case sensitive, you can make them much smaller and be able to pick them up very quickly. This layout feels right to me. I would really like a (?) hover help screen for the dialog.

In particular, having common regex expression like matching empty lines, matchin end of line, matching beginning of line. The perfect version would have a regex builder and the complete set of escape sequences ready to drag and drop into the textbox

I think symbols are more legible once you can recognize them.

PeterJones

@shodanx2 said:

run the auto-count algorithm in another thread

Multi-threaded search has been rejected on the grounds that it breaks other features:

https://github.com/notepad-plus-plus/notepad-plus-plus/issues/8329
https://github.com/notepad-plus-plus/notepad-plus-plus/issues/3562#issuecomment-2242694908

(That might be in just the context of a separate thread for each file searched during multi-file searches… but I believe that other ‘background threading’ of searching has also been rejected, though I cannot immediately find an example.)

If your live-count solution relies on one or more new threads, don’t count on it being accepted.
I think (but am not sure) that all your suggestions for “timeouts” and the like would also require threads, which would probably make them a no-go as well.

On my 156 megabytes file that is 39 milliseconds.

normal-search=href is not a complicated regular expression, and thus you have a 39ms strawman there. As I said, I have seem minutes pass while searching. If you haven’t experienced that, be thankful. But understand that freezing other people’s search dialogs for minutes before they can search, just because you want automatic “live” count, is not going to be accepted. (If that auto-count were limited to mode=normal searches, maybe, just maybe, it would be safe enough. But I’m still doubtful.)

Coises

@PeterJones said:

That might be in just the context of a separate thread for each file searched during multi-file searches… but I believe that other ‘background threading’ of searching has also been rejected, though I cannot immediately find an example.

From what I’ve seen, all search in Notepad++ runs through the Scintilla search interface. That by itself makes it impossible to separate search from the GUI thread without re-engineering how search works.

I did, somewhat, re-engineer search for Search++ and for Search in Columns++; for regular expressions, I use the raw data pointer from Scintilla and search it directly with Boost::regex. It might be possible to multi-thread Find in Open Documents that way, but probably not Replace (unless every document were duplicated in memory in the GUI thread, processed in a worker thread, then the whole document replaced in the GUI thread). One of the big hurdles I still have in Search++ is how I’m going to do Find in Files. I do not want to open each file in an off-screen Scintilla control (which I’m pretty sure is what Notepad++ does). The searching sounds simple until you consider code pages and how to locate the match in a Scintilla window if the user asks to see it by clicking in the search results. If I can design that (I just haven’t had the mental space to take on the challenge recently), doing it multi-threaded sounds like it should be possible.

Another frustrating thing is that Boost::regex doesn’t have any sort of progress callback while it is searching. It’s easy enough to do periodic callbacks after finding one instance and before finding the next (each is a separate call to Boost::regex); but often the big delays happen while searching large spans of text where nothing is found. I hope, someday, to take on the challenge of modifying Boost::regex to do a callback instead of the dreaded “too complex” message. That will be a ways down the road.

But any of this is way too much change, and way too likely to cause new bugs, for me to even think of suggesting it as a change to the base program. If anything, I think it would have to be a “parallel” feature, rather than a replacement, which would have to prove itself viable over time… which is, I’d say, appropriate for a plugin.

@shodanx2, if you’re able to code a plugin to show your concept in action so people can try it and actually demonstrate its value and reliability in real world use, that would be the way to go. If you’re throwing all this massive re-design out and thinking “somebody else” will implement it, it’s not likely; consider smaller suggestions that can be integrated without disrupting the interface with which people are familiar or the battle-tested processing of the existing program.

Alan Kilborn

@shodanx2 said:

but counting 1024 character really is not obvious

I think the idea is to just have a “feel” for how much data is selected, and set the threshold appropriate (for you) for the general need. No one is suggesting anyone count an exact number of characters.

PeterJones

@shodanx2 said:

but counting 1024 character really is not obvious

Notepad++ counts for you:

The pictured selection is 992 characters, and thus not quite past the threshold.

David Brigden52

@PeterJones

Today I Learned. 😀

Alan Kilborn

@PeterJones said:

Notepad++ counts for you

This is true; my point about “feel” was that, at least for me, if I select a “bunch” of characters with a search in mind as the next action, of course I want it to be within that selection. Again, everyone’s “bunch” could be a different number (which is why the option is configurable), and it isn’t a hard number in your mind, but there has to be a definite number for the software.

TL;DR: I have never watched the Sel: item in the status bar when making a selection for this purpose.

PeterJones

@Alan-Kilborn said:

it isn’t a hard number in your mind, but there has to be a definite number for the software.

Of course. And so you select what you “feel” is about right for your limit, and use the Sel number (rounded appropriately) to set the hard number for the preference entry.