Want to contribute code to npp

[Claudia Frank]

Can someone point me to documentation or explain what needs to be done
when I want to contribute code (pull requests) to npp?

I’ve downloaded the current repository, made changes and wanted to upload those changes using tortoisegit.

In addition do I need to request access/permission for doing it?

Cheers
Claudia

[Claudia Frank]

Just to make sure, I know how to use tortoisegit, I just want to know
the project specific guidelines like
code must be formatted in this way
changes need to be described
commit messages must contain …
etc …

Cheers
Claudia

[dail]

The guidelines for pull requests are specified in the CONTRIBUTING.md file. As these are more of guidelines than actual rules you can always look at some other PRs that have been accepted and see how those are done.

[Claudia Frank]

Hello dail,

thank you very much - well, good start, not seeing that there is such a file ;-)

Thx and cheers
Claudia

[Claudia Frank]

Hello @dail,

in order to open a pull request, it looks like I need to have my own repository
on github instead of being able to use my local one. Is this really the case?
If so, is there any other way how I could provide code as I can’t go the “repository on github” way?

Thank you
Claudia

[dail]

it looks like I need to have my own repository on github

This is correct.

is there any other way how I could provide code

You could generate a patch file of the new commit(s). Don’t know off the top of my head how to do this but I know a quick Google search will give you the info how to do it. I guess you’d then have to attach that patch file to a Github issue and hope Don takes the time to apply the patch file manually.

as I can’t go the “repository on github” way

Is there a particular reason you can’t do this?

[Claudia Frank]

You could generate a patch file of the new commit(s). Don’t know off the top of my head how to do this but I know a quick Google search will
give you the info how to do it. I guess you’d then have to attach that patch file to a Github issue and hope Don takes the time to apply the
patch file manually.
OK, thank you.

Is there a particular reason you can’t do this?
Unfortunattely yes, I’m simply not allowed to do it. One of the company rules.

Cheers
Claudia

[dail]

Unfortunattely yes, I’m simply not allowed to do it. One of the company rules.

Ah! That would make it difficult ;)