getting pull request merged?
-
Hi
I recently created a (very!) tiny pull request to fix notepad++ not being able to update behind corporate proxies that authenticate with windows integrated auth.
https://github.com/notepad-plus-plus/wingup/pull/48
My days of being active in open source development predate github (sadly real life has been too busy) so I’m not sure if there’s something else that I should do to get this merged (create an issue, perhaps) or if I should just wait until Don gets around to looking at open pull requests?
Cheers
Geoff
-
@Geoff-Winkless said in getting pull request merged?:
create an issue, perhaps
Contributing protocol says this should have been done FIRST, but I don’t know if this has any bearing on lack of attention…
-
@Alan-Kilborn said in getting pull request merged?:
says this should have been done FIRST, but I don’t know if this has any bearing on lack of attention…
@Geoff-Winkless I see you’ve now created an issue. Update your Pull Request description to include the text “Fix #49”. This will “link” the issue and pull request.
Cheers.
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login