Fix corrupted txt file (NULL)



  • @dontEatMe

    such issues are hard to track down, as you see it already took sometime before one
    found a reliable way to reproduce this issue but once found a possible fix can be coded.
    In order to help identifying/fixing such an problem it is needed to know what has been done,
    what happened and how is/was npp configured.
    And the best would be if you already know how to reproduce in a reliable way.



  • @dontEatMe said:

    i have same problem windows 7 x64 npp 7.5.9.

    This is BAD as 7.5.9 supposedly fixed this problem!



  • @dontEatMe

    if you say that some of your files got restored by previous versions of the same file using 7.5.9, some possible reasons are:

    • you have multi-instance enabled, and auto backup and periodic snapshot is enabled, and at one time you had the same file opened in 2 different instances without noticing it, where one of them was not saved, which is the version that will be restored, even though you saved the same file with newer contents at the other instance.

    • you have more than one notepad++ installed, eg. an installed one and a portable one, and auto backup and periodic snapshot is enabled, and you have modified the same file from both of them, and one of them was not saved and is restored from the snapshot that contains an older state.



  • @Alan-Kilborn said:

    This is BAD as 7.5.9 supposedly fixed this problem!

    The problem that was fixed was regarding the case you had backup turned on - in some cases a race condition occurred between backup operation and currently running action in the editor.

    There is other possible problem connected with sudden power loss but I don’t think Notepad++ is to blame for this.

    As @redneck-f25 said a few posts above:

    Anyway, after disabling the write cache on the not-write-protected disk, everything went fine.
    So probably this is NOT an error caused and CANNOT be fixed by NPP.



  • Just happened to me. Can’t even recover with the recovery software. It appears notepad++ need to improve the way it saves data, i.e. do not remove the copy of overwritten file until the saving is successful. (I was using one or two version before Notepad++ v7.7.1, have now upgraded though so can’t tell which version it was)



  • Glad to see this is still an issue 3 years after being reported. I just ran into this problem when saving and then closing the laptop lid that initiated a reboot because how else is Windows suppose to destroy your data. I will be taking this opportunity to never use notepad++ again. Thanks.



  • I am sorry to say that I cannot tell you a way to fix the corrupted files. But what I can tell you is this isn’t npps fault,
    The culprit is Windows itself. Turn this off to avoid future losses. I lost my 7 days of work to this.
    ![The culprit](6e1d09b6-f495-4cd5-91d0-4cc3badf811e-image.png image url)
    The solution:
    ![Solution](007a186c-4e3a-4331-8d1a-72507d93e965-image.png image url)



  • @Afroja-Noon ,

    You are right, although Notepad++ can use the appropriate Windows APIs to flush the write cache when saving and circumvent this.
    The common user is not obliged to know such details and deal with system configuration nonsense before doing a simple text editing.
    If I were an uninformed user and lost my saved data edited in Notepad++ I would loose trust in the editor too.

    BR



  • @pnedev said in Fix corrupted txt file (NULL):

    although Notepad++ can use the appropriate Windows APIs to flush the write cache when saving and circumvent this.

    @pnedev, were those the changes you have committed as referenced in #6133? Were any or all of those changes incorporated into the codebase? (I see that #6164 was closed, but more changes were made after that, so I’m not sure the rest of your fixes were ever incorporated.)



  • Hi @PeterJones,

    Yes, https://github.com/notepad-plus-plus/notepad-plus-plus/pull/6164 is the PR that should fix this problem but as Don decided to reject it it is not merged but simply closed.
    The later changes perhaps appear because of the patch re-bases in my Npp code clone (https://github.com/pnedev/notepad-plus-plus/commit/5397cd9030fbc23265b4d409e4c61c59ab1c8887).
    This is because I have mentioned the issue numbers in the commit message.

    BR