[NEW PLUGIN] RTL manager
-
Thanks for your replay,
I forgot to mention that, I started from the demo plugin I saw on this page, if it’s an old version then we should update that page too.
As for the dialogs I mimicked some other plugins (Hex editor mainly) since the dialogs are very simple, I didn’t want to involve .Net in the plugin just for that and other alternatives just seemed to be too complicated to start.
So what I should do next? Just replace the files from the updated versions of the template or demo?
And what are the other corrections you’re talking about? Waht’s open PRs? -
Indeed the template link is “problematic” as it is pointing to a direct vesion and not like the demo link on the same page which is linking to the release folder.
@donho Could you please adapt the link from https://github.com/npp-plugins/plugintemplate/archive/v3.zip to https://github.com/npp-plugins/plugintemplate/releases.
Also the C# link http://sourceforge.net/projects/sourcecookifier/files/other plugins/NppPlugin.NET.v0.5.zip/download is quite outdated current development is at https://github.com/kbilsted/NotepadPlusPlusPluginPack.Net -
Hello Ezra,
Thank you for this important plugin. I appreciate your work.
I’ve tested it briefly and it seems impressive and promising.
There are some issues in Double-View mode (i.e. handling the direction when NPP two views are visible).
I’ll test it more thoroughly next week and report on GitHub.Best regards.
-
@Ezra-Steinmetz Have a look at https://github.com/chcg/RTLManager/commits/cleanup with the corresponding appveyor CI build at https://ci.appveyor.com/project/chcg/rtlmanager/build/1.1.10. Mainly still failing due to missing boost lib. This could be solved by using a nuget package from https://www.nuget.org/packages/boost and https://www.nuget.org/packages/boost-vc140/ and add it to the project. There are no prebuild packages for v141 yet.
Would you like to receive a PR?
See e.g. https://github.com/npp-plugins/plugintemplate/releases, your release binaries should go there instead of a folder within the code. -
Hi
- Thanks for your bug report @Yaron, I fixed that bug and it should work now. Let me know if you find any more bugs.
- @chcg, please note I changed the project yesterday and built it with plugin template 3.1, the project you’ve forked is the old one, the new one is in the same link as in my OP.
- About the releases - I fixed that in the project but unfortunately I can’t change the download link here in the forum (my old link ends with ‘release’ as a single while the new link should end with ‘releases’ as a plural).
- I made some adjustments so that it would work with 64 bit and added the build to the GitHub resp.
- I’m a bit newbie to this all Git thing, what does receiving a pull request means in this context?
-
PR: Pull Request, see e.g. https://github.com/notepad-plus-plus/notepad-plus-plus/pulls, diffs which could be merged into your repository. But as you already changed the repo and added some of my points I first have to switch to your new repo and see what remains to be “optimized”.
-
See https://github.com/RTLManager/RTLManager/pull/1 on my suggested changes.
-
Thanks, I’ve merged that into the branch.
-
Hello Ezra,
Thank you for fixing the Double-View issue. It’s working like a charm.
I appreciate it.I have some more suggestions/requests.
With your permission, I’ll contact you on GitHub in the coming days.Best regards.
.חג שמח -
Package dir of boost just contains the serialization includes, so te nuget packages needs to be restored to be able to build. In your case probably the addiional boost include dir is available and therefore your local build is ok. See e.g. https://ci.appveyor.com/project/chcg/rtlmanager-1/build/0.8.3/job/p8i8oa8hk18xtsed
c:\projects\rtlmanager-1\src\RtlManager.h(9): fatal error C1083: Cannot open include file: 'boost/archive/binary_oarchive.hpp': No such file or directory [C:\projects\rtlmanager-1\vs.proj\NppPluginTemplate.vcxproj] c:\projects\rtlmanager-1\src\RtlManager.h(9): fatal error C1083: Cannot open include file: 'boost/archive/binary_oarchive.hpp': No such file or directory [C:\projects\rtlmanager-1\vs.proj\NppPluginTemplate.vcxproj]
-
Many many thanks, i looking for something like it for long time…
Best wishes for you