Some function key doesn't work as a shortcut

Gregory D.

Hello, I have a shortcut on the F10 that works perfectly and I’m trying to add F5 or F9 but not works, I use the standard code:

ShortcutKey* pShKey = new ShortcutKey; 
pShKey->_isAlt = false;
pShKey->_isCtrl = false;
pShKey->_isShift = false;
pShKey->_key = VK_F9;
setCommand(DOCKABLE_MY1 TEXT("Func1"), Func1, pShKey, false);

ShortcutKey* pShKey2 = new ShortcutKey;        //I changed the name to be sure
pShKey2->_isAlt = false;
pShKey2->_isCtrl = false;
pShKey2->_isShift = false;
pShKey2->_key = VK_F10;
setCommand(DOCKABLE_MY2, TEXT("FUNC2"), Func2, pShKey2, false);

Both functions work through the menu but only F10 shorcut works.
What’s the problem ?

Thanks

Ekopalypse

@Gregory-D

are you sure that your func_item array holds those in a reasonable way?

Gregory D.

Sorry I just realized that another plugin was using the same keys !

Alan Kilborn

@Gregory-D

Plugins mapping ANY keycombox is a “bad idea”.
Leave them unassigned, let users map them in Shortcut Mapper

Gregory D.

Can’t they unassign or assign them to other keys if they want ?

Ekopalypse

@Gregory-D said in Some function key doesn't work as a shortcut:

Can’t they unassign or assign them to other keys if they want ?

Of course you can, but imagine I set up npp the way I want and then I install a plugin and my settings are screwed up because the plugin overwrites them.

Gregory D.

Then you just have to modify shortcut for my plugin no ? Or it also remove already assigned shortcuts ?

Alan Kilborn

@Gregory-D said in Some function key doesn't work as a shortcut:

Then you just have to modify shortcut for my plugin no ?

We’ve already told you why this is less than good.
TWICE.
It’s getting tiring.

Or it also remove already assigned shortcuts ?

By this do you mean?: “If my plugin assigns some shortcuts, and those shortcuts are already set up in Notepad++, will my plugin remove them?”
I know the answer to this.
If you don’t, it literally takes 2 minutes of experimentation to get to to an answer.

Gregory D.

Alan, you definitively don’t like the forum concept, so why do you still make all that bad to yourself ? Just don’t replay, this is useless, and create more useless reply like this one.

@Alan-Kilborn said in Some function key doesn't work as a shortcut:

We’ve already told you why this is less than good.
TWICE.
It’s getting tiring.

You just said it’s bad, maybe you think you explain but no, you never. Ekopalypse started to explain but with you useless post maybe he won’t try to reply.

@Alan-Kilborn said in Some function key doesn't work as a shortcut:

I know the answer to this.
If you don’t, it literally takes 2 minutes of experimentation to get to to an answer.

2 minutes ? You’re probably true, but it took that to you to answer that you just “know the answer” and not giving it, this is 2 lost minutes for both. Again just don’t reply. I can ask and someone can reply or not, but replying to say yo have the answer is just…

PeterJones

@Gregory-D said in Some function key doesn't work as a shortcut:

Then you just have to modify shortcut for my plugin no ? Or it also remove already assigned shortcuts ?

So I install your plugin, then you break my keyboard shortcuts, then you think it’s okay to make me fix something you broke? Interesting philosophy.

I personally am not bothered when a plugin defines one or two shortcuts, as long as they don’t overwrite standard shortcuts. But you’ve chosen F5, F9, and F10, which are all shortcuts defined by the main Notepad++ application. By re-defining those, a user will reasonably infer that not only do you think your plugin is more important than any other plugin or user-defined configuration choices, but that your plugin is more important than standard Notepad++ workflow.

Ekopalypse

@Gregory-D

aside from what @PeterJones has said, what if your plugin is installed for multiple users?

In the end it’s your plugin and you can do whatever you want,
but ask yourself if you’re happy if your nicely set up application
suddenly behaves strangely.
It might take some time before you realize that a newly installed plugin
is the cause of the behavior.
If you don’t believe this, take some time and search the forum,
you will probably find a plethora of problems where help was asked for
and where in the end the problem was caused by a newly installed plugin.
Just a friendly advice - nothing more.