Notepad++ v8 Release Candidate

Alan Kilborn · May 20, 2021, 12:27 AM

@Artur-Harison said in Notepad++ v8 Release Candidate:

Text of inactive tab is not readable.

Seems readable to me:

The problem with saying something like “Text of inactive tab is not readable” without showing some sort of substantiating picture is that it is hard to take you seriously.

Michael Vincent · May 20, 2021, 1:57 AM

@donho said in Notepad++ v8 Release Candidate:

Enjoy!

Small “bug” with switching to/from Dark Mode. I have Preferences => General => Alternate icons enabled for the tab icons (e.g., saved, edited, etc.) Now, switch to dark mode. The tab icons no longer show; however, they are still “checked”:

Checking and unchecking the “Alternate icons” checkbox makes them appear.

Cheers.

Dark Samus · May 20, 2021, 7:43 AM

I just hate dark mode…

Please remove it or make it optional while installation.

But i want to know how you able to implement that dark UI in win32API???
Its impressive.

Artur Harison · May 20, 2021, 8:25 AM

@Alan-Kilborn

Ekopalypse · May 20, 2021, 10:42 AM

I can also confirm the behavior reported by @Michael-Vincent with the alternative icons under Windows 7.
The others, the lack of the close button in DF mode and not being able to read inactive tabs in dark mode, do not occur here.
@donho and all involved, thanks for both features, I love them already.

Edit: Forgot to mention, I do have a multi-monitor setup.

Michael Vincent · May 20, 2021, 10:54 AM

@Artur-Harison

Seems you are using a custom theme (as opposed to DarkModeDefault)? That’s on you to adjust the Settings => Style Configurator… => Inactive tabs => Foreground colour. I too use a custom theme with Dark Mode enabled, and I had to make a few minor adjustments to my theme colors so they would look good in Dark Mode as well as with Dark Mode disabled so I can switch back and forth and not need to change my theme / theme colors.

Cheers.

Michael Vincent · May 20, 2021, 10:59 AM

@Michael-Vincent said in Notepad++ v8 Release Candidate:

Small “bug” with switching to/from Dark Mode

Also seems that when restarting Notepad++ in Dark Mode, even after the “correction” to show alternate tab icons, they are not shown on restart - even though they are checked in Preferences.

Cheers.

Ekopalypse · May 20, 2021, 11:02 AM

@Michael-Vincent

Yes, same erratic behavior on Win7.

donho · May 20, 2021, 11:05 AM

@Artur-Harison

Text of inactive tab is not readable.

Obviously you have changed the theme - you can change it back to “DarkModeDefault.xml” or use Style configurator to tune the theme you have chosen.

@Michael-Vincent

The tab icons no longer show; however, they are still “checked”:

Indeed, it should be unchecked when the Dark mode is switched in. It’ll be fixed.

@Dark-Samus

Please remove it or make it optional while installation.

No. You can choose to not switch in.

But i want to know how you able to implement that dark UI in win32API???

Notepad++ is an open source project. Please check the implementation in Notepad++ repository on Github

Artur Harison · May 20, 2021, 11:12 AM

Wow! I didn’t know (or forget) what style affects on Tabs.
Thanks everyone!

Michael Vincent · May 20, 2021, 11:19 AM

@donho said in Notepad++ v8 Release Candidate:

Indeed, it should be unchecked when the Dark mode is switched in. It’ll be fixed.

Ok, but the “regular” icons don’t show either without some “clicking”.

In Dark Mode, turn “Alternate icons” off by removing the check.
close Notepad++
open Notepad++

No tab icons at all. Checking “alternate icons” turns them on:

then unchecking them makes the regular ones appear:

Cheers.

Michael Vincent · May 20, 2021, 11:25 AM

@donho said in Notepad++ v8 Release Candidate:

Enjoy

Sorry to pile on - I really do appreciate the work, but noticed an “inconsistency” in Dark Mode - maybe by design, but thought I’d ask. Early intermediate releases had some more customization on the Dark Mode preferences like keeping or coloring the menus - now it’s just on/off so don’t know if that had an effect. This is what I see:

The “top bar” is black. The status bar is not quite black - RGB=32,32,32. I actually prefer that to the complete Black RGB=0,0,0. Of course that’s my personal preference and I’m assuming “tuning” these colors is not user-configurable. Just wondering why the slight differences in the coloring for the different UI components.

NOTE: I’m on Windows 10 with system Dark Mode enabled in case that makes a difference:

Cheers.

Alan Kilborn · May 20, 2021, 11:46 AM

@Michael-Vincent

I see your points about the tab bar icons / alternate icons.

But I’d like to point out that it appears that for a “saved” file that the decision was made to have no icon at all (because it is so glaringly absent that no one would release software that way), in “dark mode” anyway.

Can @donho confirm this? If this truly is a design decision, let’s get it out there and known about, because probably hundreds of users will report it as a bug (“where’s the icon on a saved file’s tab??”).

I kind of like the cleaner look of saved files having no icon (we really only need to see the “exceptional” situations, e.g. modified, locked), but if one switches back to non-dark mode the icon comes back in that case.

Minor comment on the addition of dark mode: My first instinct is to go to Style Configurator to turn it on/off, not to a Preference page with a single item on it.

Michael Vincent · May 20, 2021, 11:57 AM

@Alan-Kilborn said in Notepad++ v8 Release Candidate:

But I’d like to point out that it appears that for a “saved” file that the decision was made to have no icon at all (because it is so glaringly absent that no one would release software that way), in “dark mode” anyway.
Can @donho confirm this? If this truly is a design decision, let’s get it out there and known about, because probably hundreds of users will report it as a bug (“where’s the icon on a saved file’s tab??”).
I kind of like the cleaner look of saved files having no icon (we really only need to see the “exceptional” situations, e.g. modified, locked), but if one switches back to non-dark mode the icon comes back in that case.

I did not know that - but if that’s the case - that certainly makes sense. I am used to seeing the alternate icon green check on saved files. If the above is true, I’m not sure my claims of a “bug” are true then. Seems the “Saved” icon just doesn’t show anymore in Dark Mode - just something I’ll have to get used to ;-)

Cheers.

Michael Vincent · May 20, 2021, 3:21 PM

@Alan-Kilborn said in Notepad++ v8 Release Candidate:

Minor comment on the addition of dark mode: My first instinct is to go to Style Configurator to turn it on/off, not to a Preference page with a single item on it.

Good point - I find myself doing that too!

donho · May 20, 2021, 7:51 PM

@Alan-Kilborn said in Notepad++ v8 Release Candidate:

But I’d like to point out that it appears that for a “saved” file that the decision was made to have no icon at all (because it is so glaringly absent that no one would release software that way), in “dark mode” anyway.

The Fluent UI icons are not made by me but by WildByDesign . So it’s his idea/intention, and I think it’s a good idea.

@Michael-Vincent
The bug’s been fixed : https://github.com/notepad-plus-plus/notepad-plus-plus/commit/156bde258ff16c7c3973874ee7302a568db109ac

donho · May 22, 2021, 10:10 AM

@dinkumoil said in Notepad++ v8 Release Candidate:

Dark mode is not really dark and plugin toolbar icons are missing:

It’s been fixed and merged into master:
https://github.com/notepad-plus-plus/notepad-plus-plus/commit/9a2dcaa5f8eb678e2b0c6494c16a8b9df37f06bb

The most of plugins need to be updated for passing the handle of ICO via hToolbarIcon instead of NULL.

xomx · May 25, 2021, 2:23 PM

I have also tried it on Win8.1 (the n++ Dark Mode looks good there), but after running n++ for a while (on the background with no user activity, just started the portable fresh n++ 8RC with the DarkMode & FluentUI icons on, nothing more), I have repeatedly obtained crash with the exception code 0xC000041d, which means STATUS_FATAL_USER_CALLBACK_EXCEPTION.

I do not have relevant PDB files, so I am only appending screenshot from MSVS how it looks like.

donho · May 26, 2021, 9:41 PM

@xomx said in Notepad++ v8 Release Candidate:

I have repeatedly obtained crash with the exception code 0xC000041d, which means STATUS_FATAL_USER_CALLBACK_EXCEPTION.

Can you reproduce it easily?
Or rather: did it happen again? ie. twice or more times.
Could you provide the debug info?
I can provide a debug binary for the examination if you can reproduce the bug steadily. 32 or 64 build do you need?

xomx · May 27, 2021, 7:44 AM

Yes, I have tried it 4 times in a row with the same result:

download and run the portable v8RC http://download.notepad-plus-plus.org/repository/8.x/8.0.RC/npp.8.0.portable.x64.7z
open n++, set Dark Mode, restart n++ and just minimize it to give it the time to crash
Unhandled exception at 0x0000000000000000 in notepad++.exe: 0xC000041D

Notepad++ v8 (64-bit)
Build time : May 18 2021 - 22:46:05
Path : C:\Notepad++\notepad++.exe
Command Line :
Admin mode : OFF
Local Conf mode : ON
Cloud Config : OFF
OS Name : Windows 8.1 Enterprise (64-bit)
OS Build : 9600.20018
Current ANSI codepage : 1250
Plugins : mimeTools.dll NppConverter.dll NppExport.dll

I can try the debug set with the pdf-files, 64-bit.