Is the shortcut mapper dialog box broken?

mkupper

I was writing up a “how to do something” for someone and ran into an issue.

For Notepad++ versions up to 8.7.5 the shortcut mapper dialog box works as expected.

For Notepad++ versions 8.7.6 to 8.8 the mapper dialog seems to be off by one letter or is blank. For example, the list of shortcuts shows Save to be Ctrl+S. If I double click on that entry it shows the shortcut to be Ctrl+T (off by one) but sometimes I’m see Ctrl+ the blank area that is above ‘None’ in the list.

Coises

@mkupper said in Is the shortcut mapper dialog box broken?:

For Notepad++ versions 8.7.6 to 8.8 the mapper dialog seems to be off by one letter or is blank. For example, the list of shortcuts shows Save to be Ctrl+S. If I double click on that entry it shows the shortcut to be Ctrl+T (off by one) but sometimes I’m see Ctrl+ the blank area that is above ‘None’ in the list.

Yes, I’m seeing that too — just that the initial value in the small Shortcut dialog is off by one the first time it is opened, and every subsequent time I’ve opened it without restarting Notepad++, it’s blank.

It appears that it only affects the initial value in that box. The value that’s actually set in that box is the one that’s used, and it is the one that appears in the list. The blank isn’t so bad, but it could be a bit confusing to see a wrong value in the box.

I wonder if it could be related to Add ShortcutMapper MultiLingual ability which was Notepad++ v8.7.6 release item 4? Just a guess; I have not attempted to test that hypothesis.

guy038

Hello, @mkupper, @peterjones and All,

I confirm the Shorcut Mapper bug on portable N++ versions 8.7.6, 8.7.9 and 8.8 RC2. The last version OK is v8.7.5

Peter, I do hope, that your nice improvement regarding the OEM keys which follow current keyboard do NOT introduce this bug ?!

Best Regards,

guy038

PeterJones

@guy038 said in Is the shortcut mapper dialog box broken?:

Peter, I do hope, that your nice improvement regarding the OEM keys which follow current keyboard do NOT introduce this bug ?!

Unfortunately, since the problem started in v8.7.6, and my improvement was released in v8.7.6, and nothing else touched the mapper between those, it must’ve been. I thought I had thoroughly tested, but I can confirm the problem as well,

The good news is, it uses the shortcut that you actually enter after changing it… but if you open the dialog again, it goes off-by-one or on subsequent times, showing no shortcut. I’ll start digging into it.

@mkupper , if you could put in a bug report, I will “claim it” (assign it to me)

mkupper

Thank you @Coises and @guy038 for the confirmation plus additional info and @PeterJones for the offer to fix this. I have created https://github.com/notepad-plus-plus/notepad-plus-plus/issues/16491

mkupper

@PeterJones There’s a bit of good news in that the updater is still stuck on v8.7.5 meaning most people have not been affected by this bug. See https://notepad-plus-plus.org/update/getDownloadUrl.php?version=7.00&param=x64

PeterJones

@mkupper ,

My branch ~~is currently building~~ has built artifacts for what I hope is a fix. Could you download the appropriate artifact for your installed Notepad++, and see if this build fixes it for you?

Update: Link removed, since the fix has been confirmed

guy038

Hi, @mkupper, @coises, @peterjones and All,

@peterjones, I personally downloaded the Notepad++.MSVC.x64.Release.zip archive and test the new notepad++.exe v8.8

I’m pleased to tell you that the bug seems fixed !!

Many thanks for this quick fix :-))

BR

guy038

mkupper

@PeterJones said in Is the shortcut mapper dialog box broken?:

Could you download the appropriate artifact for your installed Notepad++, and see if this build fixes it for you?

I’m now using both the MSVC.x64.Release and MSVC.Win32.Release Notepad++.exe files. The shortcut mapper issue has been fixed. Thank you @PeterJones