Search++: A work in progress

[Coises]

@guy038 said in Search++: A work in progress:

@coises, very sorry about the supposed bug with the Bookmarks feature ! Finally, I understood that this bug happens ONLY IF you choose the ICU regex engine ! If you’re using the Plain or Regex options, everything woks as expected ;-)) Is there a limitation to use Bookmarks when the true ICU regex engine is active ?

Nothing to be sorry about — thank you for the observation, and for narrowing down to ICU. I see what’s wrong: it’s a coding error. I’ll fix it.

I even noticed that, like with the native Mark dialog, if you have, both, bookmarks and marked text in current document and that the Bookmark lines when marking text option, in Tools, is unchecked, a Remove marks and bookmarks from active document action does not clear the Bookmarks, as expected !

If you look closely, when Bookmark lines when marking text is checked, the menu item should say Remove marks and bookmarks from active document; when Bookmark lines when marking text is not checked, that menu item should say Remove marks from active document.

(I’m not sure why I didn’t make the same change to Remove marks from multiple documents…, since it also removes bookmarks as well if Bookmark lines is checked.)

It could be that this is a confusing way to do it. I intended to make the Bookmark lines setting so that when it’s checked, bookmarks and marks “go together” for Mark and Show commands and for Remove marks; but when it’s not checked, Search++ only affects marks and does nothing with bookmarks.

Except that Add selection to marked text doesn’t also add bookmarks regardless of whether Bookmark lines is checked.

This does need refinement. There is certainly some inconsistency. I do want to preserve the ability to manipulate marks without touching bookmarks at all; but which commands should affect bookmarks, and whether I need separate commands for some kinds of bookmark manipulation, remains an open question.

[guy038]

Hello, @coises an All,

Regarding the two behaviors of the Replace command :

• First, I suppose that a special mark/sign/icon in the Search++ title zone, to clearly identify the current behavior of the Replace action, would be welcome !

• Then, the user will choose its desired behavior, simply using the Ctrl + J shortcut.

• And forget my idea of a new setting ! In this specific case, the user will begin using the alternate Replace behavior first then, after some tries, he would toogle to the usual Replace behavior !

---

Now, do we need the additional sub-menu in order to occasionally use the opposite Replace behavior, without changing the default settings, as you expressed ?

To my mind, after using this opposite behavior ( so, of course, changing the default behavior ), the user would just have to hit the Ctrl + J shortcut again to restore the previous default !

In addition, I probably forget some edge cases and, anyway, it’s your plugin, not my baby !

BR

guy038

[Coises]

@guy038 said in Search++: A work in progress:

Regarding the two behaviors of the Replace command :

• First, I suppose that a special mark/sign/icon in the Search++ title zone, to clearly identify the current behavior of the Replace action, would be welcome !

It is indicated by the icon on the Replace button. Is there some reason that isn’t enough?

Now, do we need the additional sub-menu in order to occasionally use the opposite Replace behavior, without changing the default settings, as you expressed ?

I agree that the “opposite jump behavior” sub-menu isn’t strictly necessary, but I don’t think it does any harm, either. To my mind, the commands on that menu are still commands that “belong to” the Replace button. If anything, it’s the Jump to next match after Replace option on the Tools menu that strikes me as logically redundant; but I wanted something to which I could assign that Ctrl+J shortcut for easy switching.

If user experience indicates that the sub-menu creates more confusion than convenience, I’ll remove it.

[guy038]

Hello, @coises,

When I said :

• First, I suppose that a special mark/sign/icon in the Search++ title zone, to clearly identify the current behavior of the Replace action, would be welcome !

You answered me :

It is indicated by the icon on the Replace button . Is there some reason that isn’t enough?

 🡪   replace then jump to a new match forward
 🡨   replace then jump to a new match backward
 🡪❚  replace and highlight replacement; next click finds a new match forward
 ❚🡨  replace and highlight replacement; next click finds a new match backward

You’re certainly younger than me and/or have very good eyes ! I did notice that symbol at right of the Replace button but, it seems a bit tiny !

Best Regards,

guy038

P.S. :

Perhaps it would be a good idea to specify, in the manual, that :

• All sections concerning regular expressions and formulas work correctly when the regex button is selected !

• When the ICU button is selected, you could also point out that the important features, below, are NOT supported :

  • The \K construction

  • All the Backtracking Control verbs, like (*SKIP) or (*F)

  • All the symbolic names, except for [[:ascii.]]

  • The invalid UTF-8 characters, like [[.x80.]] or [[.xff.]]

  • The \l and \u syntaxes as shorthand of [[:lowercase letter:]] and [[:uppercase letter:]] ( which are the [[:upper:]] and [[:lower:]] equivalents when the Regex button is selected ! )

[Coises]

@guy038 said in Search++: A work in progress:

When I said :

• First, I suppose that a special mark/sign/icon in the Search++ title zone, to clearly identify the current behavior of the Replace action, would be welcome !

You answered me :

It is indicated by the icon on the Replace button . Is there some reason that isn’t enough?

 🡪   replace then jump to a new match forward
 🡨   replace then jump to a new match backward
 🡪❚  replace and highlight replacement; next click finds a new match forward
 ❚🡨  replace and highlight replacement; next click finds a new match backward

You’re certainly younger than me and/or have very good eyes ! I did notice that symbol at right of the Replace button but, it seems a bit tiny !

Thank you for the observation. I consider those symbols important in general (not just for this specific case) because they remind you if you’ve click-selected one of the alternatives from the drop-down menus. Before Search++ can be considered ready for a first “stable” release, I have to make sure they are clearly legible. (I used symbols instead of words because the buttons would have to be much bigger to show the full command names as used in the drop-down menus, and that in turn would make the minimum useful size of the dialog much bigger.)

I’m 68 — I don’t know if that’s younger than you. It’s surely not that my eyes are that good. One of the main things I wanted to accomplish in Search++ was using Scintilla controls for the find and replace text, partly because I’m so tired of struggling to read what I’ve typed into those boxes in Notepad++ and Columns++ searches. (The other main reason was to avoid the complications that arise with line endings and “invisible” characters in the standard Windows controls.)

So I think it’s either that I can see the difference in the two symbols because I know what I’m looking for — after all, I don’t have any trouble with the buttons and check boxes in standard search dialogs, and their font is the same as the one in the find and replace boxes — or they aren’t displaying the same on all systems. (Or both.)

For development purposes, to keep things simple, I’ve used Unicode characters for the symbols on the buttons. That has somewhat limited my choice of symbols, as well as given me no control over the size and weight (aside from finding a different symbol). It could also be the case that they display differently on different systems. Which all means that using Unicode symbol characters is a bad way to do this. At some point I will need to replace them using a different method that will be more complex, but will give me more control.

Are you using a high-dpi monitor, by any chance? At present I do not have one available for testing. I have read various information from Microsoft about it, but information without actual practice tends to turn into gibberish… at this point I don’t think I can adequately predict how this will look on high dpi.

Perhaps it would be a good idea to specify, in the manual, that :

• All sections concerning regular expressions and formulas work correctly when the regex button is selected !

• When the ICU button is selected, you could also point out that the important features, below, are NOT supported :

  • The \K construction

  • All the Backtracking Control verbs, like (*SKIP) or (*F)

  • All the symbolic names, except for [[:ascii.]]

  • The invalid UTF-8 characters, like [[.x80.]] or [[.xff.]]

Indeed, my documentation says very little about the ICU search at present. At some point before a first “stable” release I will either document the ICU search more thoroughly or “hide” it so users won’t stumble on it and be confused by it.

• The \l and \u syntaxes as shorthand of [[:lowercase letter:]] and [[:uppercase letter:]] ( which are the [[:upper:]] and [[:lower:]] equivalents when the Regex button is selected ! )

A minor note: this is a point in which Search++ Regex differs from Columns++ as a result of changes I made to use ICU as the source of information for Unicode properties instead of the mechanism I cobbled together in Columns++.

In Columns++, \l and [[:lower:]] are equivalent to [[:lowercase letter:]] (or [[:Ll:]], or \p{Ll}) — 2,283 matches in your Total_Chars.txt file.

In Search++ Regex, \l and [[:lower:]] are equivalent to (?-i)[[:lower:]] in ICU — 2,595 matches in Total_Chars.txt.

You can still use [[:lowercase letter:]] (or [[:Ll:]], or \p{Ll}) in Search++ Regex to match the same 2,283 characters as (?-i)[[:lowercase letter:]] in ICU.

Unlike ICU, both Columns++ and Search++ Regex ignore case insensitivity when matching named character classes (including the \l and \u shorthands).

[guy038]

Hi, @coises,

Well, I’m 74. Now, with my glasses I have nearly 20/20 vision in my left eye but only 3/10 in my right eye, due to a vascular problem in the retina that I had about 10 years ago :-((

No, I don’t have an high-dpi monitor and here is a snapshot of the Replace button, in exact size :

Of course, if I look at the button, I’m able to notice the mark →❙, after the word Replace, but I may miss it sometimes !

---

Thank you, to point out the specificities and differences about the character classes regarding Columns ++ and Search ++,

So, here is a summary on this topic :

•==============================•=============•================•=========================================================================•
|               Regex          |  Columns++  | Search++ Regex |                              Search++ ICU                               |
•==============================•=============•================•==============•==========================================================•
|  (?-i)\l                     |    2,283    |      2,595     |         1    |  Letter l                                                |
|  (?-i)[[:lower:]]            |    2,283    |      2,595     |     2,595    |  = (?-i)\p{Ll} + (?-i)\p{Other Lowercase} = 2,283 + 312  |
|                              |             |                |              |                                                          |
|  (?-i)\p{Ll}                 |    2,283    |      2,283     |     2,283    |                                                          |
|  (?-i)[[:lowercase letter:]] |    2,283    |      2,283     |     2,283    |                                                          |
|  (?-i)[[:Ll:]]               |    2,283    |      2,283     |     2,283    |                                                          |
•------------------------------•-------------•----------------•--------------•----------------------------------------------------------•
|  (?-i)\u                     |    1,886    |      2,006     |    Invalid   |  ???                                                     |
|  (?-i)[[:upper:]]            |    1,886    |      2,006     |     2,006    |  = (?-i)\p{Lu} + (?-i)\p{Other Uppercase} = 1,886 + 120  |
|                              |             |                |              |                                                          |
|  (?-i)\p{Lu}                 |    1,886    |      1,886     |     1,886    |                                                          |
|  (?-i)[[:Uppercase letter:]] |    1,886    |      1,886     |     1,886    |                                                          |
|  (?-i)[[:Lu:]]               |    1,886    |      1,886     |     1,886    |                                                          |
•==============================•=============•================•==============•==========================================================•
|  (?i)\l                      |    2,283    |      2,595     |         2    |  Letters L and l                                         |
|  (?i)[[:lower:]]             |    2,283    |      2,595     |     4,082    |                                                          |
|                              |             |                |              |                                                          |
|  (?i)\p{Ll}                  |    2,283    |      2,283     |     3,729    |                                                          |
|  (?i)[[:lowercase letter:]]  |    2,283    |      2,283     |     3,729    |                                                          |
|  (?i)[[:Ll:]]                |    2,283    |      2,283     |     3,729    |                                                          |
•------------------------------•-------------•----------------•--------------•----------------------------------------------------------•
|  (?i)\u                      |    1,886    |      2,006     |    Invalid   |  ???                                                     |
|  (?i)[[:upper:]]             |    1,886    |      2,006     |     3,484    |                                                          |
|                              |             |                |              |                                                          |
|  (?i)\p{Lu}                  |    1,886    |      1,886     |     3,322    |                                                          |
|  (?i)[[:Uppercase letter:]]  |    1,886    |      1,886     |     3,322    |                                                          |
|  (?i)[[:Lu:]]                |    1,886    |      1,886     |     3,322    |                                                          |
•==============================•=============•================•==============•==========================================================•

Note that all the properties, below, are used internally by the Unicode Cconsortium for generating other properties and are not intended to be used stand-alone. These properties only contribute to real properties so there’s no direct support for these properties in ICU and they all return the Invalid regular expression message !

\p{Jamo_Short_Name}                      \p{JSN}
\p{Other Alphabetic}                      \p{OAlpha} 
\p{Other Default Ignorable Code Point}    \p{ODI}    
\p{Other Grapheme Extend}                 \p{OGr Ext}
\p{Other ID Continue}                     \p{OIDC}   
\p{Other ID Start}                        \p{OIDS}   
\p{Other Lowercase}                       \p{OLower} 
\p{Other Math}                            \p{OMath}  
\p{Other Uppercase}                       \p{OUpper} 

You can verify the number of characters, in these categories, from the files https://www.unicode.org/Public/UCD/latest/ucd/PropList.txt and https://www.unicode.org/Public/UCD/latest/ucd/Jamo.txt

Best regards

guy038

[Coises]

@guy038 said in Search++: A work in progress:

No, I don’t have an high-dpi monitor and here is a snapshot of the Replace button, in exact size :

The proportion is a bit different on my system:

so it seems the display does differ from system to system. I will find a way to make those icons more recognizable and obvious… I just don’t know when.

[Lachlanmax]

@Coises
It works great for me in this version.

I especially like the Remove Marks option and how well it works together with the bookmarks. That combination feels very natural in the workflow now.

For the moment I would not suggest any changes, it already feels quite solid for how I use it.
Thanks for the good work you did for my requests!

[guy038]

Hello, @coises and All,

I almost finished to study all the ICU syntax mainly focused on Unicode properties and, so far, all the results seem coherent ;-))

---

However, I noticed something strange about the property Numeric_Value

To this purpose, refer to https://www.unicode.org/Public/UCD/latest/ucd/extracted/DerivedNumericValues.txt

For any number which has a finite number of decimal places, like 0.1875 or 0.4, located after the equal sign, in the \p{Numeric_Value=....} syntax, the returned result is always correct. For example, \p{Numeric_Value=0.25} or \p{nv=025} returns 14 matches, as you may verify in the Unicode file

However, for any number which has an infinite number of decimal places, like 0.333333333333 or 0.142857142857, located after the equal sign, in the \p{Numeric_Value=....} syntax, the returned result is always 0 instead of an integer > 0

In addition, the special value \p{Numeric_Value=NaN} should return 323,567, against my Total_chars.txt file, instead of the value 0 !

---

Is there any chance that you truncated the decimal part in Search ++ or something like that ?

Best Regards,

guy038

[Coises]

@guy038 said in Search++: A work in progress:

Is there any chance that you truncated the decimal part in Search ++ or something like that ?

No. I did not mess with the ICU search at all; the string entered in the Find box is exactly what ICU’s regular expression engine gets.

I see that \p{nv=0.3333333333333333} (or any greater number of 3s) returns six matches. Likewise, \p{nv=0.66666666666666667} returns seven matches, but fewer 6s returns none.

Since the ICU4C function u_getNumericValue(UChar32 c) returns a double, I would guess that matching is dependent on the precise quirks of double-precision floating point format.

In addition, the special value \p{Numeric_Value=NaN} should return 323,567, against my Total_chars.txt file, instead of the value 0 !

There might not be anything you can enter that will be translated as Not-a-Number. I note that \p{Numeric_Type=None} does return 323,567 matches.