Multiple errors building NPP 7.5.6

Claudia Frank · Mar 20, 2018, 1:22 PM

Hi Yaron,

long time not seen - how you are doing, hopefully fine.
As of MS, those should be available in <sys\stat.h>
Maybe you need to include this in VS 2013 CE explicitly.

Cheers
Claudia

Vitaliy Dovgan · Mar 20, 2018, 3:36 PM

That must be my fault - I compiled Notepad++ only in VS 2015, did not try the 2013 one.
The additional #include <sys/stat.h> should fix it indeed.

Yaron · Mar 20, 2018, 4:55 PM

Hello Claudia,

It’s always a pleasure to communicate with you.
I’m fine, thank you. I hope you’re as well.

Adding #include <sys/stat.h> to Common.cpp has indeed solved the errors appearing in the screenshot above.

I’m still getting the these errors.

Could you please enlighten me as to how you found <sys/stat.h>?
Did you search _S_IREAD?

Thank you for your kind help. I do appreciate it.

Hello Vitaliy,

Thank you for your reply too. Appreciated.

Best regards.

Claudia Frank · Mar 20, 2018, 5:58 PM

@Yaron

thx, I’m fine.

Yes,actually I was searching for _S_IREAD and _S_IEXEC
and I always add msdn if it is development related,
to the search to get the MS ones first.

But looks like there is something in addition missed.
Let’s see what the gitlog says about changes.

'Till then …

Cheers
Claudia

Claudia Frank · Mar 20, 2018, 6:14 PM

@Yaron

the new version uses keywords like noexcept which aren’t available for
VS versions < 2015, so we either could try to hack around by defining macros
changing source code etc… or you need to update to a newer VS.

Btw. I’m really impressed about VS2017 which works even on my old pc and
running in a virtual machine very well.

Cheers
Claudia

Vitaliy Dovgan · Mar 20, 2018, 7:14 PM

VS 2013 does not completely comply even with C++11, not saying about C++14, so a newer version of VS is recommended.
It may be strange to hear such words from a person who wants Notepad++ to be compatible with Windows XP and who was still using VS 2005 (together with VS 2013, though) just a year or two ago, but:

VS 2015 and VS 2017 does support Windows XP targeting and
the newer VS version is used the more latest C++ features are available to the developers.

Taking this into account, as well as the availability of free Community or Express versions of latest VS, there is no much sense in staying on VS 2013 - plus, VS 2013 and VS 2015 or newer can co-exist under the very same system, if there is a need to still have VS 2013.

Yaron · Mar 20, 2018, 8:05 PM

Hello Claudia,

Thanks again for looking into it and solving the problem. I do appreciate it.

I understand I should be able to build NPP with VS 2017 (using notepadPlus.vcxproj and not notepadPlus.vs2013.vcxproj), correct?

VS installation is quite mammoth. :)
How would you handle it? Completely uninstalling VS 2013 (assuming I don’t need it)?

Hello Vitaliy,

Thank you for the additional info. I appreciate that.

Best regards.

Claudia Frank · Mar 20, 2018, 8:11 PM

Hi Yaron,

if you don’t need VS2013 anymore, why wasting GB of space - remove it
but as Vitaliy stated, both can coexist just in case you still need it.
Unfortunately VS2017 forces you to have windows account otherwise you can’t
unlock the test version and yes, the vcxproj is the one I used as well.

Cheers
Claudia

Yaron · Mar 20, 2018, 9:24 PM

Hello Claudia,

Thanks again for your kind help. Appreciated as always.

Best regards.

Yaron · Mar 28, 2018, 7:48 PM

Hello Claudia and Vitaliy,

Last week I installed VS 2017 Community and built NPP 7.5.6.
Thanks again for your help.

I tried today to check Preferences -> General -> Document List Panel - Show and NPP crashed.
Thinking it was due to some of my code changes, I downloaded the repository again and built it as is. The same result - NPP crashes.

Building:
I doubled clicked notepadPlus.vcxproj, was prompted to add support for xp and built the solution.

Using the original binary included in the official packages, the crash does not occur.
Any idea?

Best regards.

Claudia Frank · Mar 28, 2018, 8:28 PM

Hi @Yaron ,

as I did - but no crashes so far
and is this reproducible?

Which VS version do you run?

Microsoft Visual Studio Community 2017 
Version 15.6.3
VisualStudio.15.Release/15.6.3+27428.2011
Microsoft .NET Framework
Version 4.7.02558

Installed Version: Community

Did you change something on the build process? Build events?
How do you start npp? From within the build directory?
x64 or x32 ? (I tested only x64)

Cheers
Claudia

Yaron · Mar 28, 2018, 8:57 PM

Hello Claudia,

Thank you very much for the prompt reply. I do appreciate it.

The only thing I modified was from x64 to x86 and to Release instead of Debug.
No errors or warnings.

I’ve used it for a few days without any problem.
Trying today to display the Document List Panel, the crash happened.
It is consistent; whenever I try to check that option NPP crashes.

I downloaded a fresh portable NPP and replaced the binary with my build.

Best regards.

Claudia Frank · Mar 28, 2018, 9:24 PM

Yaron, just did a x86 release build and looks ok - I guess you assumed that this is the case.

From the code I only could guess that there might be a problem with your configuration files.

If you have downloaded an official zipped package, could you replace the
official builded npp exe with the one you build and run it within this directory.

If this works then it indicates that one of your configuration files is corrupt.

If it doesn’t work … hmmm … which operating system do you run?

Cheers
Claudia

Yaron · Mar 28, 2018, 9:32 PM

Hello Claudia,

Thanks again for your time and effort.

If you have downloaded an official zipped package, could you replace the
official builded npp exe with the one you build and run it within this directory.

That is just what I have done. :)
Win 7 x32.

Best regards.

Claudia Frank · Mar 28, 2018, 9:39 PM

I thought you did it the other way, you copied the official exe to your directory
but I was looking for copying your exe to the official unzipped directory, so that
your exe is running with the official configuration files.
Or did you already check both ways?

Cheers
Claudia

Yaron · Mar 28, 2018, 9:51 PM

Both ways.

Thanks again. Appreciated.

Claudia Frank · Mar 28, 2018, 9:57 PM

Yaron ,

then I would say time to debug. Either run from within VS (copy everything to the build
directory) or attach it to the running exe, but then make sure the pdb files are found.
Just for info - I have to stay up early tomorrow so I have to stop here.
But if there is anything I could do we can follow up tomorrow night :-)

Cheers
Claudia

Yaron · Mar 28, 2018, 10:05 PM

Hello Claudia,

I’ve never used the Debugger. :)
It might also be some general setting I’ve modified in VS.
We’ll see tomorrow.

Thanks again and good night.

Yaron · Mar 29, 2018, 8:32 PM

Hello Claudia,

I’ve created a Dump file, opened it in VS and used “Debug with Native Only”.

Interestingly, if I check Hide Extension Column first and then Show - the crash does not happen.

Whenever you have some free time. Thanks again.

Best regards.

Claudia Frank · Mar 29, 2018, 8:33 PM

Hi Yaron,

can you set a breakpoint onto line 100 in VerticalFileSwitchesListView.cpp
like here

run the project by pressing F5, once npp appears do the setting changes
and then when VS comes up with the breakpoint step through it with F10
until you receive the access denied exception, then we know which
part exactly throws that exception.

Cheers
Claudia