Find and Display *All* Duplicate Lines

PeterJones

@Yaron said in Find and Display *All* Duplicate Lines:

It’s a basic functionality IMO. :)

Mail servers have harsh anti-spam for sending, and forum outgoing emails looks like spam to most servers. Without paying for an outgoing mail server that allows emails from forums, the chances are low that anything that we can do will counteract that. And Don isn’t going to pay for such a server.

And as I pointed out in the FAQ back in the days when it didn’t work at all: the regulars (some, like you and I, who have been here for 8+ years, during which this feature worked for fewer than 8 months, so less than 1/12 of the time we’ve been involved in the forum), have survived the vast majority if the forum’s existence (in this format) without the email notifications – it’s nice to have, but IMO not a critical feature.

I will contact him, but there is no guarantee we can get it to work, or that he’s interested in spending any more time on that feature of the forum.

Alan Kilborn

@mkupper said in Find and Display *All* Duplicate Lines:

One puzzle is that it intermittently creates random selections when I double click

Hmm, I have not been able to duplicate this. I set up a test file of 25000 lines of random sentences (one per line), then I duplicated 10 of these lines, then random-sorted the file. Then I ran the script and tried to recreate what you are seeing from double-clicking in the results file, and could not. :-(

Alan Kilborn

Side note:

Someone asked me via chat why the output file has a .sr extension. The sr stands for “search results”; I tried to emulate Notepad++'s Search results format in the output I created.

Another reason is that I have a UDL that I made for .sr files which colorizes the output somewhat like N++'s Search results, sample of that:

guy038

Hello, @yaron, @coises, @mkupper, @alan-kilborn and All,

@alan-kilborn, just a minor bug ( or a possible decision on your part ! ) :

Let’s write this text in a new tab :

This is a test
This is a test

    This is a second test
    This is a second test

        This is a third test
        This is a third test
        This is a third test

	This is a fouth test
	This is a fouth test
	This is a fouth test
	This is a fouth test

		This is the last test
		This is the last test
		This is the last test
		This is the last test
		This is the last test

Then, running your valuable script, we get this DupeLineResults.sr :

Search DUPLICATE LINES (5 sets) in "new 1"
  Set-1 text: This is a test
	Line 1
	Line 2
  Set-2 text: This is a second test
	Line 4
	Line 5
  Set-3 text: This is a third test
	Line 7
	Line 8
	Line 9
  Set-4 text: This is a fourth test
	Line 11
	Line 12
	Line 13
	Line 14
  Set-5 text: This is the last test
	Line 16
	Line 17
	Line 18
	Line 19
	Line 20

I personally was expecting :

Search DUPLICATE LINES (5 sets) in "new 1"
  Set-1 text: This is a test
	Line 1
	Line 2
  Set-2 text:     This is a second test
	Line 4
	Line 5
  Set-3 text:         This is a third test
	Line 7
	Line 8
	Line 9
  Set-4 text: 	This is a fourth test
	Line 11
	Line 12
	Line 13
	Line 14
  Set-5 text: 		This is the last test
	Line 16
	Line 17
	Line 18
	Line 19
	Line 20

Where the text, located after the regex string Set-\d+ text:\x20, should be identical to the text in current file

@mkupper, I think that :

When you click on a line of the DupeLineResults.sr file in order to jump to curent file, it’s best to cancel any previous selection before doing the double-clic !
Do NOT click on any line Set-### text: ......... Else, you get errors on the Python Console !

Best Regards,

guy038

Alan Kilborn

@guy038 said in Find and Display *All* Duplicate Lines:

Do NOT click on any line Set-### text: … Else, you get errors on the Python Console !

Yea. Bug. The line_in_source_file = line should be placed after the following if m: line.

Alan Kilborn

@guy038 said in Find and Display *All* Duplicate Lines:

just a minor bug ( or a possible decision on your part ! )

No bug. It was a design decision to NOT show leading whitespace on the duplicate line text.

If you don’t like it, easy enough to remove .lstrip() from where it occurs in the code.

guy038

Hi, @alan-kilborn and All,

Sorry, Alan, but the two modifications fail :-((

Whatever the choice, I get the message :

Traceback (most recent call last):
  File "D:\@@\792\plugins\Config\PythonScript\scripts\Test_Alan.py", line 89, in doubleclick_callback
    if m:
AttributeError: 'NoneType' object has no attribute 'group'

BTW, don’t rely, on the line number as I added some comments at the beginning of script

Deleting the .lstrip() string leave the lines Set-### text: ........ as they were before, without any change !

BR

guy038

Alan Kilborn

@guy038 said in Find and Display *All* Duplicate Lines:

but the two modifications fail

Did you restart Notepad++ after making the modifications?

BTW, these lines control that:

if __name__ == '__main__':
    try:
        fadadl
    except NameError:
        fadadl = FADADL()
    fadadl.run()

The first time the script is run during a Notepad++ invocation (don’t want to use the word “session” here), fadadl doesn’t exist, so the NameError happens and the fadadl = FADADL() line executes (key part: registering the callback), and then the run method is called.

Because the callback is already there the second and later times the script is executed, the fadadl = FADADL() line does NOT execute; we don’t want multiple copies of the callback (otherwise a double-click on a Line x line would run the same callback code two or even more times). Thus any changes you’ve made to the code do not get picked up, and only the run method is called (with the code that was in place during the first execution).

There are other ways to accomplish these goals, but I’ve never fully trusted trying to remove an existing callback. I consider needing to restart Notepad++ a small limitation, because most users would just use the script, not modify it.

I hope this makes sense.

mkupper

@Alan-Kilborn and others.

I’m still getting and puzzling over the random selections issue. I don’t have any selections active and so for now have been trimming my test file down. At present it’s 787 lines of plain ASCII with no line longer than 100 characters.

As you and others are not seeing the issue with larger files I’m going to change tactics and set up a bare bones portable v8.6 x32. My day to day installed copy of Notepad++ has cruft from many years of upgrading and is also x32 for compatibility with a couple of obsolete plugins. It’s using PythonScript version 2 which I assume is still available.

guy038

Hello, @alan-kilborn and All,

Oh…yes. Alan, I am unforgivable and deeply sorry ! Of course, everything worked fine after I stopped and restarted Notepad++. ;-))

Just a lesson : No good to be too lazy. Things must be run on the right order !

Best Regards,

guy038

P.S. :

Finally, I understand your design decision… once you’re no longer surprised to see several sets that seem to concern only one set !

Alan Kilborn

@mkupper said in Find and Display *All* Duplicate Lines:

I’m still getting and puzzling over the random selections issue.

Is it only a “random selection” issue? That is, if you pretend the selection isn’t there, does your caret (at one end of the selection) end up on the correct line? If that’s the case, maybe we can simply cancel the selection.

It seems maybe there is something of a race going on here. The double-click makes Scintilla want to do something in the current (results) file – it wants to select a double-clicked word – but maybe that processing is somehow delayed until the source file is activated, and then bogus positions are used as Scintilla finishes making its selection? This goes against my understanding of how it should work but…

Michael Vincent

@Alan-Kilborn said in Find and Display *All* Duplicate Lines:

output file has a .sr extension. The sr stands for “search results”; I tried to emulate Notepad++'s Search results format in the output I created.

Another reason is that I have a UDL that I made for .sr files which colorizes the output

A bit off topic for this current discussion, but Notepad++ has a “lexer” for “Internal Search” called “searchResult” that has entries in both ‘langs.model.xml’ and ‘stylers.model.xml’. You can see it in:

https://github.com/notepad-plus-plus/notepad-plus-plus/blob/97dd708e233559a4a0bd819f7ee72892c27e1a66/PowerEditor/src/ScintillaComponent/ScintillaEditView.cpp#L116

The “lexer” is set here:

notepad-plus-plus/PowerEditor/src/ScintillaComponent/FindReplaceDlg.cpp:
640: 	if (_scintView.execute(SCI_GETLEXER) == SCLEX_NULL)
641: 	{
642: 		_scintView.setLexer(L_SEARCHRESULT, LIST_NONE); // Restore searchResult lexer in case the lexer was changed to SCLEX_NULL in GotoFoundLine()
643: 	}

which through setLexer() eventually calls:

notepad-plus-plus/PowerEditor/src/ScintillaComponent/ScintillaEditView.cpp:
2165: bool ScintillaEditView::setLexerFromLangID(int langID) // Internal lexer only
2166: {
2167: 	if (langID >= L_EXTERNAL)
2168: 		return false;
2169: 
2170: 	const char* lexerNameID = _langNameInfoArray[langID]._lexerID;
2171: 	execute(SCI_SETILEXER, 0, reinterpret_cast<LPARAM>(CreateLexer(lexerNameID)));
2172: 	return true;
2173: }

That functionality can be “duplicated” in PythonScript and in fact I have a “hidder Lexer” script based on work from @PeterJones and others that can enable some of Lexilla’s lexers that N++ does not expose. I’m wondering why we can’t just:

from ctypes import windll, addressof, create_unicode_buffer
from ctypes.wintypes import HWND, UINT, WPARAM, LPARAM

from Npp import editor, notepad

SendMessage          = windll.user32.SendMessageW;
SendMessage.argtypes = [HWND, UINT, WPARAM, LPARAM]
SendMessage.restype  = LPARAM

NPPM_CREATELEXER = (1024 + 1000 + 110)

_lexer     = create_unicode_buffer('searchResult')

ilexer_ptr = SendMessage(notepad.hwnd, NPPM_CREATELEXER, 0, addressof(_lexer))
editor.setILexer(ilexer_ptr)

editor.colourise(0, -1)

which (I hope) is the smallest self-contained example of what my hidder Lexer script does. I tried this but it does not lex the document as “searchResult” or “Internal Search”. I’m sure it’s a bit different in that I’m not trying to activate a Lexilla lexer, but this lexer name seems to be defined and used within N++, I wonder why PythonScript cannot activate it?

Cheers.

mkupper

@Alan-Kilborn said in Find and Display *All* Duplicate Lines:

Is it only a “random selection” issue? That is, if you pretend the selection isn’t there, does your caret (at one end of the selection) end up on the correct line? If that’s the case, maybe we can simply cancel the selection.

When a selection happens I am taken to the middle of a page with the selection ending at the line I’m on. The intended target line is on the page, sometimes it’s top line that is visible, and sometimes the target line is at the at the bottom of the visible page.

This item is unrelated to the random selection issue. I don’t know if it’s by design but sometimes double clicking takes me to a page with the target line at the very top and other times the target is at the very bottom of the selected page. This slows me down because after double clicking I need to then visually find the newly selected line. The choice of top or bottom seems random, even when retesting a line such as 6208.

I now have two workarounds as I understand better what is happening with the random top/bottom combined with the intermittent appearance of a selection. When I get a selection I can go back to DupeLineResults.sr and double click again. The odds are it will work.

Another workaround is to be mindful of the line number I intend to go to when double clicking in DupeLineResults.sr. If I get a selection then I know the line I want is either the first or last line on the page and so can look for it and move there without needing to re-run the double-click.

The glitch is intermittent and can’t be solved by just cancelling the selection. However, a possible workaround in the code is to fetch the current line number. If you are not on the expected line then cancel the selection and re-run going to the target line.

When I double click in DupeLineResults.sr I’m seeing that one of three things will happen:

I am taken to the selected line which is positioned at the top of the page.
I am taken to the selected line which is positioned at the bottom of the page. This seems to happen more often than being taken to the top of the page.
I am taken to the middle of a page though trending towards the upper half and will have a selection running from the top of the page to my spot in the middle. The intended target line has always been either the first or last visible line on the page. The selection has always started far up the file and tends to be near the top.

I don’t know if it matters but I run Notepad++ (and all apps) in full screen mode and have a single monitor. It lets me focus on what I’m working on. My fingers are well versed in the keystrokes needed to navigate among tabs of those apps that have tabs and are well versed in Alt-Tabbing to other apps.

Alan Kilborn

@mkupper said in Find and Display *All* Duplicate Lines:

sometimes it’s top line that is visible, and sometimes the target line is at the at the bottom of the visible page

The problem you are experiencing seems to go deeper than this, but I will say that there isn’t a guarantee as to where in the viewport a line that you are moving to will appear.

Scintilla documentation for .gotoLine for example, says, “…scrolls the view (if needed) to make it (the line) visible”.

Programmers can pull extra duty to ensure that a line appears in the viewport where they want it to; example HERE.

mkupper

@Alan-Kilborn said in Find and Display *All* Duplicate Lines:

The problem you are experiencing seems to go deeper than this, but I will say that there isn’t a guarantee as to where in the viewport a line that you are moving to will appear.

Scintilla documentation for .gotoLine for example, says, “…scrolls the view (if needed) to make it (the line) visible”.

I agree that the problem I’m experiencing is odd. I was thinking about what the FindAndDisplayAllDuplicateLines.py script could be racing with and so disabled TextFX which I found I had finally weeded myself from using. That did not help the selection issue.

I tried to detect a pattern of the top or bottom of the viewport and did not see one while also getting intermittent selections. My current installation of Notepad++ seems to be nearly bare-bones. I think the only non-default plugin is PythonScript.

The next step for me is to set up a fresh portable installation.

PeterJones

Moderator note: When typing names of files with two-letter extensions, some extensions map to known TopLevelDomains, which makes NodeBB linkify those filenames as URLs.

So the “search results” .sr suffix is trying to linkify to domains assigned to Suriname, and .py suffix is trying to linkify domains assigned to Paraguay. Whether or not those domains actually exist, it’s not a good idea to link to them: spam bots that are crawling the web see links to non-existent domains, and they may try to buy those domains and put nefarious websites behind those links just to get a few more victims.

I have red-texted the links I noticed in this discussion… but when you are previewing your post, if you see something in link color that you don’t expect, please go back and red-textify it, so that I don’t have to.

Alan Kilborn

@PeterJones said in Find and Display *All* Duplicate Lines:

When typing names of files with two-letter extensions, some extensions map to known TopLevelDomains, which makes NodeBB linkify those filenames as URLs.

I always wondered why it did that – go to know.
In the past I’ve sometimes red-texted the name of scripts, but not always; didn’t realize there was possibly some harm to come from not doing it.
I’ll attempt to remember to do filenames in red-text from now on.

Alan Kilborn

@Michael-Vincent said in Find and Display *All* Duplicate Lines:

this lexer name seems to be defined and used within N++, I wonder why PythonScript cannot activate it?

I agree with the sentiment, and a while ago I actually tried go get this going – but not to the level it seems you did. I was also unsuccessful. I had some offline chats with @Ekopalypse about it; I don’t think we got to a working solution. :-(

Ekopalypse

@Alan-Kilborn @Michael-Vincent

Afaik the problem is that the “search result” lexer uses an internal structure MarkingsStruct that contains the results to which it refers.

Ekopalypse

I used my lunch break productively :-)
Please note that this only works if the corresponding search has taken place, i.e.
You cannot save the search result in a file and reapply the styling when loading.

from ctypes import (cdll, windll, create_string_buffer, create_unicode_buffer,
    addressof, pointer, WINFUNCTYPE)
from ctypes.wintypes import BOOL, HWND, LPARAM, WPARAM, UINT

from Npp import editor2, notepad

SendMessage          = windll.user32.SendMessageW
SendMessage.argtypes = [HWND, UINT, WPARAM, LPARAM]
SendMessage.restype  = LPARAM

NPPM_CREATELEXER = (1024 + 1000 + 110)

WNDENUMPROC = WINFUNCTYPE(BOOL, HWND, LPARAM)

FindWindowEx = windll.user32.FindWindowExW
GetWindowText = windll.user32.GetWindowTextW
GetWindowTextLength = windll.user32.GetWindowTextLengthW
EnumChildWindows = windll.user32.EnumChildWindows
GetClassName = windll.user32.GetClassNameW


nppHandle = notepad.hwnd
curr_class = create_unicode_buffer(256)
WM_CLOSE = 0x010
window_hwnds = {}

SEARCH_WINDOW = 'Search results'

def foreach_window(hwnd, lParam):
    if curr_class[:GetClassName(hwnd, curr_class, 256)] == '#32770':
        length = GetWindowTextLength(hwnd)
        if length > 0:
            buff = create_unicode_buffer(length + 1)
            GetWindowText(hwnd, buff, length + 1)
            if buff.value == SEARCH_WINDOW:
                window_hwnds[buff.value] = hwnd
                return False
    return True

EnumChildWindows(nppHandle, WNDENUMPROC(foreach_window), 0)

if SEARCH_WINDOW in window_hwnds:
    SCI_GETPROPERTY = 4008
    sci_hwnd = FindWindowEx(window_hwnds[SEARCH_WINDOW], None, 'Scintilla', None)

    mark_struct = create_string_buffer(b'@MarkingsStruct')
    mark_struct_ptr = addressof(mark_struct)

    length = SendMessage(sci_hwnd, SCI_GETPROPERTY, mark_struct_ptr, 0)
    buffer = create_string_buffer(length+1)
    SendMessage(sci_hwnd, SCI_GETPROPERTY, mark_struct_ptr, addressof(buffer))

    _lexer = create_unicode_buffer('searchResult')

    ilexer_ptr = SendMessage(notepad.hwnd, NPPM_CREATELEXER, 0, addressof(_lexer))
    editor2.setILexer(ilexer_ptr)
    editor2.setProperty('@MarkingsStruct', buffer.value)
    editor2.styleSetFore(1, (224, 108, 117))
    editor2.styleSetFore(2, (229, 192, 123))
    editor2.styleSetFore(3, (209, 154, 102))
    editor2.styleSetFore(4, (97, 175, 239))
    editor2.colourise(0, -1)

Note the use of editor2!