Community
    • Login

    getting pull request merged?

    Scheduled Pinned Locked Moved Notepad++ & Plugin Development
    3 Posts 3 Posters 293 Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • Geoff WinklessG
      Geoff Winkless
      last edited by

      Hi

      I recently created a (very!) tiny pull request to fix notepad++ not being able to update behind corporate proxies that authenticate with windows integrated auth.

      https://github.com/notepad-plus-plus/wingup/pull/48

      My days of being active in open source development predate github (sadly real life has been too busy) so I’m not sure if there’s something else that I should do to get this merged (create an issue, perhaps) or if I should just wait until Don gets around to looking at open pull requests?

      Cheers

      Geoff

      Alan KilbornA 1 Reply Last reply Reply Quote 2
      • Alan KilbornA
        Alan Kilborn @Geoff Winkless
        last edited by Alan Kilborn

        @Geoff-Winkless said in getting pull request merged?:

        create an issue, perhaps

        Contributing protocol says this should have been done FIRST, but I don’t know if this has any bearing on lack of attention…

        Michael VincentM 1 Reply Last reply Reply Quote 3
        • Michael VincentM
          Michael Vincent @Alan Kilborn
          last edited by

          @Alan-Kilborn said in getting pull request merged?:

          says this should have been done FIRST, but I don’t know if this has any bearing on lack of attention…

          @Geoff-Winkless I see you’ve now created an issue. Update your Pull Request description to include the text “Fix #49”. This will “link” the issue and pull request.

          Cheers.

          1 Reply Last reply Reply Quote 4
          • First post
            Last post
          The Community of users of the Notepad++ text editor.
          Powered by NodeBB | Contributors